SaaS Configuration module #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jptissot
commented
Mar 18, 2021
src/Modules/StatCan.OrchardCore.SaaSConfiguration/Drivers/SaaSConfigurationDisplayDriver.cs
Show resolved
Hide resolved
jptissot
added
the
wait-to-merge
jptissot
commented
Mar 26, 2021
src/Modules/StatCan.OrchardCore.SaaSConfiguration/Services/SaaSConfigurationService.cs
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.SaaSConfiguration/Services/SaaSConfigurationService.cs
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.SaaSConfiguration/Services/SaaSConfigurationService.cs
Show resolved
Hide resolved
src/Modules/StatCan.OrchardCore.SaaSConfiguration/Services/SaaSConfigurationService.cs
Show resolved
Hide resolved
|
Todo: Switch the Recipe execution to a separate feature + add Zip recipe execution. |
jptissot
commented
Mar 26, 2021
| <div class="form-group" asp-validation-class-for="SelectedTenantNames"> | ||
| <label asp-for="SelectedTenantNames">@T["Tenants"]</label> | ||
| <div class="row"> | ||
| @for (var i = 0; i < Model.AllTenants.Count; i++) |
There was a problem hiding this comment.
Create a Razor component for this as it might be useful for many different views
jptissot
commented
Mar 26, 2021
|
|
||
| it("SaaSConfiguration module sets up the openid server properly", function() { | ||
| cy.login(tenant); | ||
| cy.enableFeature(tenant, "StatCan_OrchardCore_SaaSConfiguration_Client"); |
There was a problem hiding this comment.
Elaborate on this test.
There was a problem hiding this comment.
This should test the default tenant settings update.
jptissot
removed
the
wait-to-merge
|
Some things left on this PR
|
|
Fails on first load, had to save the settings of the server. Had to load the OpenId server settings page and hit save for the configuration to work. |
jptissot
commented
Apr 21, 2021
| authority = saasConfigurationSettings.Authority; | ||
|
|
||
| await saasConfigurationService.UpdateRedirectUris(currentUri.ToString()); | ||
| }); |
There was a problem hiding this comment.
ActivateShell = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191
Todo: