Combine base notebook cpu gpu images #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zachomedia you are going to have to review this as can't quite make sense of it. |
JessicaBarh
changed the title
Closed
ca-scribner
reviewed
Nov 17, 2020
|
closes #122 |
|
@zachomedia this is ready for you to review. The main change is that instead of:
That, and there's now CI enabled for PR's to master in addition to merging into master, which allows debugging CI without actually merging into master. |
ca-scribner
approved these changes
Nov 17, 2020
JessicaBarh
force-pushed
the
combine-cpu-gpu-images
branch
from
1797d6f to
1f21211
Compare
|
@zachomedia can you review this today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Relates to PR #129 that is being split up into smaller PRs for better review.
Resolves part of: #146
Refactored base-notebook-gpu. upstream-equivalent-notebook-gpu will be built on the fly by this CI from a SHA-pinned pull of GPU-Jupyter to create the GPU equivalent to docker-stacks' datascience-notebook, which is our CPU upstream image. This lets both CPU and GPU versions of base-notebook be identical except for the upstream image.