Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encapsulate repetitive steps in CI #154

Conversation

JessicaBarh
Copy link
Contributor

@JessicaBarh JessicaBarh commented Nov 19, 2020

The build instructions for each notebook in CI are repetitive and can be encapsulated into a helper script to make it easier to read and easier for dev's to test building locally.

This Relates to PR #129 that is being split up into smaller PRs for review - see issue #146

@JessicaBarh JessicaBarh changed the title update: run CI on PR's vs branch encapsulate repetitive steps in CI Nov 19, 2020
@JessicaBarh JessicaBarh force-pushed the encapsulate-repetitive-steps-in-CI branch from 910c48a to 7c3e5ab Compare November 20, 2020 22:47
@JessicaBarh JessicaBarh marked this pull request as ready for review November 20, 2020 22:51
Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but should get an outsider to review too (maybe Blair or Brendan?)

.github/workflows/build-cpu.yml Outdated Show resolved Hide resolved
scripts/build_push.sh Outdated Show resolved Hide resolved
@sylus sylus closed this Nov 27, 2020
@JessicaBarh JessicaBarh deleted the encapsulate-repetitive-steps-in-CI branch December 18, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants