-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): Add apps component jupyter-web-app #125
Conversation
Doesn't the cluster role(s) come from Kubeflow are we performing adjustments on it? |
@zachomedia in the example above should we own the cluster roles or just apply our deltas via a strategic merge? |
Overall this looks great @rohank07 just checking one thing and then will merge it. |
Hey @rohank07 I might be wrong but I dont see a difference in output when commenting out: # using a valueFrom instead of value
patches:
- target:
kind: Deployment
name: jupyter-web-app-deployment
patch: |-
- op: remove
path: /spec/template/spec/containers/0/env/1/value
- op: remove
path: /spec/template/spec/containers/0/env/2/value |
Hey @rohank07 i made a few tiny adjustments but the end manifest is still the same. Are you ok if i merge this? |
Okay to merge! Yeah, no differences in the patch 😅 |
Signed-off-by: rohank07 rohank_17@hotmail.ca