upgrade(apps): jwa 1.6 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything but one thing looks good to me, would you mind fixing the one issue though? I don't think this label is correct anymore? enabledCondition:
labels:
- state.aaw.statcan.gc.ca/exists-non-sas-notebook-user: false
+ state.aaw.statcan.gc.ca/non-employee-users: falseThe only thing else I see is some further role permissions and the addition of JWA_APP_SECURE_COOKIES |
rohank07
force-pushed
the
update-jwa-1.6
branch
from
ee09e67 to
eb837fd
Compare
|
@rohank07 I don't think this is still what the final label will be? |
rohank07
force-pushed
the
update-jwa-1.6
branch
from
eb837fd to
05b6692
Compare
|
@sylus Updated to use the new label |
sylus
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #231