Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jupyter-api): update sha #273

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

Jose-Matsuda
Copy link
Contributor

@Jose-Matsuda Jose-Matsuda commented Oct 19, 2022

Was this feature StatCan/jupyter-apis#164
but ci failed and had to fix it in this workflow https://github.com/StatCan/jupyter-apis/actions/runs/3276232912

@Jose-Matsuda Jose-Matsuda marked this pull request as draft October 19, 2022 12:44
@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Oct 19, 2022

Well this is awkward, I swear to you this worked when testing locally
image

Might need top update the spawner_ui config defaults

@Jose-Matsuda
Copy link
Contributor Author

Bryan has fixed the object object in StatCan/jupyter-apis#174

Copy link
Contributor

@rohank07 rohank07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jose-Matsuda Jose-Matsuda merged commit a32f0f9 into aaw-dev-cc-00 Nov 3, 2022
@Jose-Matsuda Jose-Matsuda deleted the update-jupyter-api-sha branch November 3, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants