Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase Kubeflow onto v1.6.0 #1341

Closed
Tracked by #1337
wg102 opened this issue Sep 7, 2022 · 1 comment · Fixed by StatCan/kubeflow#99
Closed
Tracked by #1337

Rebase Kubeflow onto v1.6.0 #1341

wg102 opened this issue Sep 7, 2022 · 1 comment · Fixed by StatCan/kubeflow#99
Assignees
Labels
component/kubeflow Kubeflow Related

Comments

@wg102
Copy link
Contributor

wg102 commented Sep 7, 2022

Rebase Kubeflow onto v1.6.0!

Rebase the kubeflow for upstream on v1.6.0 (found here: https://github.com/kubeflow/kubeflow/tree/v1.6.0).

Rebase Steps

The following steps have been taken to rebase:

git clone https://github.com/StatCan/kubeflow
cd kubeflow
git remote add upstream https://github.com/kubeflow/kubeflow
git fetch upstream
git remote –v # check remotes are configured correctly
git checkout stc-master
git checkout –b bryan-rebase-1.4-to-1.6
git rebase v1.6.0
# resolve conflicts...
git commit -m "rebase message..."
git push --set-upstream origin bryan-rebase-1.4-to-1.6

Note

There is some discussion upstream on kubeflow/kubeflow#6332 about changing the central-dashboard from polymer to angular, which I do hope will happen, but currently does not seem to have been done. This will affect us greatly for obvious reason.

Local testing of Kubeflow

To simulate having a namespace.

Be carefull not to be connected to prod.

Then open two terminals and enter one of the following commands into one terminal and the other commands into the second terminal:

kubectl port-forward -n kubeflow deployment/profiles-deployment 8081:8081
USERID_HEADER=kubeflow-userid USERID_PREFIX= KF_USER_ID=User.Name@cloud.statcan.ca npm run dev
@wg102 wg102 added the component/kubeflow Kubeflow Related label Sep 7, 2022
@wg102 wg102 assigned bryanpaget and unassigned mathis-marcotte Sep 8, 2022
@wg102 wg102 changed the title Rebase kubeflow to 1.6-rc3 Rebase kubeflow to 1.6.0 Sep 9, 2022
@bryanpaget bryanpaget changed the title Rebase kubeflow to 1.6.0 Rebase Kubeflow onto v1.6.0 Sep 12, 2022
@bryanpaget
Copy link
Contributor

bryanpaget commented Sep 13, 2022

Linked PR: StatCan/kubeflow#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubeflow Kubeflow Related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants