Kubeflow 1.4->1.6 Rebase

[bryanpaget]

Closes StatCan/aaw#1341

Thank you @brendangadd, @Souheil-Yazji for the following instructions on how to rebase:

git remote add upstream https://github.com/kubeflow/kubeflow/
git checkout upstream/master # make sure you have the forked repo's master locally
git checkout stc-master
git pull
git checkout -b {your-new-branch-to-rebase-fork}
git reset $(git merge-base upstream/master $(git branch --show-current)) # this will reset your current branch to a good merge base between it and the upstream master, essentially the idea is to undo all commits not on upstream master
git add .
git commit -m "commit message"
git rebase upstream/v1.6.0

I tried to stay upstream as much as possible.

The folders I tended to take our changes from were:

components/centraldashboard
components/notebook-controller
.github/workflows

Testing

npm run test client

Testing the client gives:

TOTAL: 1 FAILED, 65 SUCCESS

npm run test-server

Testing the server gives:

Summary:

👊  Passed
Suites:  19 of 19
Specs:   45 of 45
Expects: 111 (0 failures)
Finished in 0.393 seconds

See below for test output.

[bryanpaget]

Linked Issue: StatCan/aaw#1341

[Jose-Matsuda]

Seems we lost a commit from Saffa somewhere along the way

See 8de6feb , I cannot seem to find these lines of code anymore.

Having said this, this line of code may need to change anyways with how we are changing how the logic around SAS works, may want to confirm with the team about this, may need to look at the other related files in her PR as well to make sure that her changes are still in here.

[Jose-Matsuda]

Address the comments made and I think we good

[bryanpaget]

Seems we lost a commit from Saffa somewhere along the way

See 8de6feb , I cannot seem to find these lines of code anymore.

Having said this, this line of code may need to change anyways with how we are changing how the logic around SAS works, may want to confirm with the team about this, may need to look at the other related files in her PR as well to make sure that her changes are still in here.

I've added it back! :-)

[Jose-Matsuda]

Seems we lost a commit from Saffa somewhere along the way
See 8de6feb , I cannot seem to find these lines of code anymore.
Having said this, this line of code may need to change anyways with how we are changing how the logic around SAS works, may want to confirm with the team about this, may need to look at the other related files in her PR as well to make sure that her changes are still in here.

I've added it back! :-)

Ooops we still missing a tiny bit inside the languages.json file.

[Jose-Matsuda]

looks better now i think