Skip to content

Commit

Permalink
chore(limit): modify as well (#334)
Browse files Browse the repository at this point in the history
* chore(html): update the submission
  • Loading branch information
Jose-Matsuda authored Dec 12, 2024
1 parent 283535a commit 69bbf3c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions frontend/jupyter/cypress/e2e/form-page.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ describe('New notebook form', () => {
cy.get('[data-cy-advanced-options-button]').click();
cy.get('[data-cy-form-input="cpu"]').find('input').clear();
// minimum value
cy.get('[data-cy-form-input="cpu"]').find('input').type('0.1');
cy.get('[data-cy-form-input="cpu"]').find('input').type('0.01');
cy.get('[data-cy-form-input="cpu"]')
.find('input')
.should('have.class', 'ng-invalid');
cy.get('[data-cy-form-input="cpu"]')
.find('mat-error')
.should('have.text', 'Specify at least 0.5 CPUs');
.should('have.text', 'Specify at least 0.1 CPUs');
cy.get('[data-cy-form-input="cpu"]').find('input').clear();
// maximum value
cy.get('[data-cy-form-input="cpu"]').find('input').type('40.0');
Expand Down Expand Up @@ -166,7 +166,7 @@ describe('New notebook form', () => {
.should('have.class', 'ng-invalid');
cy.get('[data-cy-form-input="memory"]')
.find('mat-error')
.should('have.text', 'Specify at least 1Gi of memory');
.should('have.text', 'Specify at least 0.5Gi of memory');
cy.get('[data-cy-form-input="memory"]').find('input').clear();
// maximum value
cy.get('[data-cy-form-input="memory"]').find('input').type('90.0');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
[attr.disabled]="readonlySpecs ? '' : null"
matInput
type="number"
min="0.5"
min="0.1"
step="0.1"
formControlName="cpu"
[errorStateMatcher]="matcher"
Expand All @@ -38,7 +38,7 @@
[attr.disabled]="readonlySpecs ? '' : null"
matInput
type="number"
min="1"
min="0.5"
step="0.1"
formControlName="memory"
[errorStateMatcher]="matcher"
Expand Down

0 comments on commit 69bbf3c

Please sign in to comment.