Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure to destroy old notebook volumes #18

Closed
ca-scribner opened this issue May 11, 2020 · 3 comments · Fixed by #20
Closed

Procedure to destroy old notebook volumes #18

ca-scribner opened this issue May 11, 2020 · 3 comments · Fixed by #20
Assignees
Labels
area/ux Requires attention from UX: focus on user interaction or UI design component/kubeflow kind/design kind/feature priority/soon size/L 4-5 days

Comments

@ca-scribner
Copy link
Contributor

Every notebook server by default creates a volume. Users can optionally create additional persistent volumes at notebook creation. These are not destroyed at notebook termination.

Possible solutions:

  • do we care? If we don't mind having these persist indefinitely, close this :)
  • do we have an existing way for users to cull these.
    • If yes: add it to docs for storage
    • If no: should we?
  • do we have automated garbage detection for the system to notice when users aren't culling these themselves?
@blairdrummond
Copy link

My thinking is that we probably need to create a good notification system somehow. Have an automated culling policy (that's super easy I think), and give users a 30,15,1 day heads-up before their pvcs get culled, unless they attach the PVCs.

@blairdrummond
Copy link

We can probably revisit this (eventually) now that we have a notification system in place from the Orchard folks. We can send warning emails well in advance.

@brendangadd brendangadd transferred this issue from StatCan/aaw Sep 1, 2020
@brendangadd brendangadd added area/ux Requires attention from UX: focus on user interaction or UI design component/kubeflow kind/design kind/feature priority/soon size/L 4-5 days labels Sep 1, 2020
@brendangadd
Copy link
Contributor

brendangadd commented Sep 1, 2020

As a user, I want to see all my notebook volumes and delete the ones I don't need.

Let's add UI to the Jupyter web app component of Kubeflow to enable listing and deletion of persistent volumes.

  • List all of (and only) the volumes owned by the user
  • Only allow deletion of volumes that are not in use – probably equivalent PVC not being mounted

The logic for displaying volumes and allowing deletion is probably similar to that which displays the list of existing volumes available to be attached to a new notebook server.

Edit: Shouldn't have to work with PVs themselves, but rather the associated PVCs. I think these PVs are automatically cleaned up when there is no bound PVC.

/cc @wg102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Requires attention from UX: focus on user interaction or UI design component/kubeflow kind/design kind/feature priority/soon size/L 4-5 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants