Support notebook volume (PVC) management #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendangadd
suggested changes
Sep 15, 2020
frontend/src/app/main-table/volumes-table/volume-table.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
wg102
force-pushed
the
18-destroy-old-notebooks
branch
from
ae76680 to
421ad7f
Compare
wg102
force-pushed
the
18-destroy-old-notebooks
branch
from
421ad7f to
2095188
Compare
* Add icons to headers of the two tables under the main-table component * Refactor code for cleaner use of promises * Show user size of volumes in table * Show user what notebooks volumes are mounted to
brendangadd
suggested changes
Oct 1, 2020
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
brendangadd
changed the title
brendangadd
suggested changes
Oct 2, 2020
frontend/src/app/main-table/resource-table/resource-table.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/main-table/volumes-table/volume-table.component.ts
Outdated
Show resolved
Hide resolved
saffaalvi
force-pushed
the
18-destroy-old-notebooks
branch
from
a3a4bee to
48ecf01
Compare
saffaalvi
force-pushed
the
18-destroy-old-notebooks
branch
from
aba9c16 to
49fc2b3
Compare
Switch to a tristate PVC status so that the volume management table can indicate whether a volume is mounted, unmounted, or being deleted.
brendangadd
approved these changes
Oct 6, 2020
saffaalvi
pushed a commit
that referenced
this pull request
Feb 11, 2021
Support notebook volume (PVC) management
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18
Note:
Since the data is now passed through main-table: