Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter-apis index frontend to KF1.7 #218

Closed
18 tasks done
mathis-marcotte opened this issue Apr 17, 2023 · 0 comments
Closed
18 tasks done

Update jupyter-apis index frontend to KF1.7 #218

mathis-marcotte opened this issue Apr 17, 2023 · 0 comments
Assignees

Comments

@mathis-marcotte
Copy link
Contributor

mathis-marcotte commented Apr 17, 2023

Epic StatCan/aaw#1632

Update the frontend for the index section of jupyter-apis to match upstream while making sure to not remove our custom code.

For the volume table, make sure to look in here. This will be another ticket

This would also include adding the notebook details and the volume details pages. another ticket

SRC App Pages Index

jupyter/frontend/src/app/pages/index

  • index.component.html
  • index.component.scss
  • index.component.spec.ts
  • index.component.ts
  • index.module.ts

jupyter/frontend/src/app/pages/index/index-default

  • config.ts : Seems like more properties got added to the table column configs, mainly the sort. We'll have to make sure to update our column definitions if needed for the volume and cost tables.
  • index-default.module.ts
  • index-default.component.scss
  • index-default.component.html
  • index-default.component.spec.ts
  • index-default.component.ts : The way the backend is called for the notebooks changed. So that caused a bit more conflicts with our other custom calls for the volume and kubecost data.

jupyter/frontend/src/app/pages/index/index-default/server-type

  • server-type.component.ts
  • server-type.component.scss
  • server-type.component.spec.ts
  • server-type.component.html

jupyter/frontend/src/app/pages/index/index-rok
(We dont use this component so just copying it all)

  • index-rok.component.spec.ts
  • index-rok.component.ts
  • index-rok.module.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant