Kf1.7 jupyter apis index frontend #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wg102
requested changes
May 30, 2023
Comment on lines
56
to
62
| filteringPreprocessorFn: element => { | ||
| if (element.serverType === 'group-one') { | ||
| return 'vscode Visual Studio Code'; | ||
| } else if (element.serverType === 'group-two') { | ||
| return 'rstudio'; | ||
| } else { | ||
| return 'jupyterlab'; |
There was a problem hiding this comment.
If they mentioned the two groups + jupyterlab, do we want to add our third group to this option or wait...
There was a problem hiding this comment.
oh you are correct! Ill go update that now
mathis-marcotte
added a commit
that referenced
this pull request
Jun 28, 2023
* Update common folder (#227) * Code update Common Folder * added notebook page (#233) Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * added volume-details-page (#234) Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * Kf1.7 jupyter apis index frontend (#235) * updated jupyter index files --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * Update jupyter general (#239) General code in all folders * Kf1.7 jupyter form update (#236) * renamed form-default to form-new * updated form for 1.7 --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * Kf1.7 jupyter backend (#228) * updated get pvcs request * updated poddefaults return response * added new jupyter endpoints * updated access review spec * added new volume endpoints * updated readme for thunder client --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * Kf1.7 volume table stuff (#241) * imported volume components --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * fixes to be able to run jupyter-apis (#242) * fixes to be able to run jupyter-apis * index related fixes * revert change in namespace * fixed some form issues * fixed some issues with the details page * fixed monaco-editor for loading * hid volumes form * fixed the custom image checkbox hiding images * fixed some bugs with the form-image * revert the form images * fixed some more issues * updated go package --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * fixed vulnerabilities (#246) Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * deleted useless packa-lock file * reverted change to build-angular package version * Kf1.7 vulnerabilities (#247) * fixed vulnerabilities for common * fixed vulnerabilities for jupyter frontend --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * Kf1.7 frontend js tests (#248) * fixes to be able to run jupyter-apis * index related fixes * revert change in namespace * fixed some form issues * fixed some issues with the details page * fixed monaco-editor for loading * hid volumes form * fixed the custom image checkbox hiding images * fixed some bugs with the form-image * revert the form images * fixed some more issues * updated go package * fixed some of the issues with the js tests --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * fixed bug with declarations * set docker image to node 16 * Kf1.7 cypress (#249) * kf1.7 cypress update * fixed cypress tests --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * fixed semver vulnerability issue * kf1.7 added new workflows (#250) * added new workflows * testing with different triggers * ran prettier to format * fixed lint picking up node_modules * deleted workflow that got replaced * ran prettier on jupyter * initial lint fix for jupyter * write prettier on jupyter * jupyter lint * more formatting and linting * fixed issues * formatting --------- Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca> * removed old tslint file * updated golang version * updated go version * updated readme --------- Co-authored-by: Wendy Gaultier <wendy.gaultier2@canada.ca> Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #218
Added the file index-default.component.ts in the i18n ticket since there are some new text in there