Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common folder #227

Merged
merged 7 commits into from
May 25, 2023
Merged

Update common folder #227

merged 7 commits into from
May 25, 2023

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented May 24, 2023

Closes #226

@wg102 wg102 requested a review from mathis-marcotte May 24, 2023 15:15
Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments of things to confirm

Copy link
Contributor

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wg102 wg102 merged commit 565c5f9 into kf1.7-upgrade May 25, 2023
@wg102 wg102 deleted the update-common-folder branch May 25, 2023 15:20
mathis-marcotte added a commit that referenced this pull request Jun 28, 2023
* Update common folder (#227)

* Code update Common Folder

* added notebook page (#233)

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* added volume-details-page (#234)

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* Kf1.7 jupyter apis index frontend (#235)

* updated jupyter index files

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* Update jupyter general (#239)

General code in all folders

* Kf1.7 jupyter form update (#236)

* renamed form-default to form-new

* updated form for 1.7

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* Kf1.7 jupyter backend (#228)

* updated get pvcs request

* updated poddefaults return response

* added new jupyter endpoints

* updated access review spec

* added new volume endpoints

* updated readme for thunder client

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* Kf1.7 volume table stuff (#241)

* imported volume components

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* fixes to be able to run jupyter-apis (#242)

* fixes to be able to run jupyter-apis

* index related fixes

* revert change in namespace

* fixed some form issues

* fixed some issues with the details page

* fixed monaco-editor for loading

* hid volumes form

* fixed the custom image checkbox hiding images

* fixed some bugs with the form-image

* revert the form images

* fixed some more issues

* updated go package

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* fixed vulnerabilities (#246)

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* deleted useless packa-lock file

* reverted change to build-angular package version

* Kf1.7 vulnerabilities (#247)

* fixed vulnerabilities for common

* fixed vulnerabilities for jupyter frontend

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* Kf1.7 frontend js tests (#248)

* fixes to be able to run jupyter-apis

* index related fixes

* revert change in namespace

* fixed some form issues

* fixed some issues with the details page

* fixed monaco-editor for loading

* hid volumes form

* fixed the custom image checkbox hiding images

* fixed some bugs with the form-image

* revert the form images

* fixed some more issues

* updated go package

* fixed some of the issues with the js tests

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* fixed bug with declarations

* set docker image to node 16

* Kf1.7 cypress (#249)

* kf1.7 cypress update

* fixed cypress tests

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* fixed semver vulnerability issue

* kf1.7 added new workflows (#250)

* added new workflows

* testing with different triggers

* ran prettier to format

* fixed lint picking up node_modules

* deleted workflow that got replaced

* ran prettier on jupyter

* initial lint fix for jupyter

* write prettier on jupyter

* jupyter lint

* more formatting and linting

* fixed issues

* formatting

---------

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>

* removed old tslint file

* updated golang version

* updated go version

* updated readme

---------

Co-authored-by: Wendy Gaultier <wendy.gaultier2@canada.ca>
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants