-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jupyter-apis i18n to KF1.7 #221
Comments
Notes from other tickets:projects/kubeflow/src/lib/confirm-dialog:
projects/kubeflow/src/lib/content-list-item:
projects/kubeflow/src/lib/editor: New folder
projects/kubeflow/src/lib/editor/interfaces: New folder
projects/kubeflow/src/lib/form/rok-url-input:
section.component.html : Customization conflict.
projects/kubeflow/src/lib/help-popover: New
projects/kubeflow/src/lib/loading-spinner:
projects/kubeflow/src/lib/logs-viewer: New namespace-select.component.html
projects/kubeflow/src/lib/resource-table/action:
projects/kubeflow/src/lib/resource-table/component-value:
projects/kubeflow/src/lib/resource-table/types:
projects/kubeflow/src/lib/resource-table/table:
table.component.html
namespace.service.ts It's like if there was only half a refactor on the file projects/kubeflow/src/lib/status-icon: New
projects/kubeflow/src/lib/title-actions-toolbar:
projects/kubeflow/src/lib/variables-groups-table:
|
Will need translationsfrontend/jupyter/src/app/pages/index/index-default
|
Will need to translate |
Looked into the xliffmerge type of tools but they weren't really working, or working well enough, when i looked into them. Either our angular version was blocking them from being installed or some other issues like the outputs weren't really any better than what we have. |
Looks like some text was added under frontend/common/kubeflow/kubeflow-common-lib. We have never had text to have to update coming from that part of the repo, and since it is split from frontend/jupyter where our i18n is setup, it is not being currently translated. |
Since the text was all mostly in the common table component, decided to just make it so that that text is an input of that component. So that means we can set the text in our frontend/jupyter side of the app and translate it there, and then send the translated text to the kubeflow-common-lib side of the app. |
Once all the code is updated for the frontend, we should make sure to run
npm run i18n:extract
to update the messages files for our translations, and also add any missing translation.Since updating xliff files can be annoying, maybe we can look into a tool like xliffmerge to help us out.
List of files
I18n
jupyter/frontend/i18n/fr
jupyter/frontend/i18n/
jupyter/frontend/src/app/pages/form/form-new/form-cpu-ram
jupyter/frontend/src/app/pages/form/form-new/form-data-volumes
jupyter/frontend/src/app/pages/form/form-new/form-image
There is also new text we will need to figure out for this one for the description of the SAS image
The text was updated successfully, but these errors were encountered: