Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kubecost table and fix i18n #115

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Remove kubecost table and fix i18n #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/jupyter/src/app/pages/form/form-default/volume/volume.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<!-- Volume Name Input -->
<mat-form-field appearance="outline" id="name">
<mat-label>Name</mat-label>
<mat-label>{{ 'common.name' | translate }}</mat-label>
<input
matInput
formControlName="name"
Expand Down
9 changes: 7 additions & 2 deletions frontend/jupyter/src/app/pages/index/index-default/index-default.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@
(actionsEmitter)="reactVolumeToAction($event)"
></lib-resource-table>

<lib-resource-table *ngIf="this.getCostStatus() == true; else error"
<!-- todo: Fix kubecost -->
<!-- <lib-resource-table *ngIf="this.getCostStatus() == true; else error"
[config]="costConfig"
[data]="processedCostData"
[trackByFn]="costTrackByFn"
></lib-resource-table>
></lib-resource-table> -->

<div class="center-flex ">
<p>{{ 'jupyter.costTable.kubeCostError' | translate }}</p>
</div>

<ng-template #error>
<div *ngIf="this.getCostStatus() == false" class="center-flex costerror">
Expand Down
3 changes: 2 additions & 1 deletion frontend/jupyter/src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@
"gpus": "GPUs",
"storage": "Storage",
"total": "Total",
"errMessage": "Failed to retrieve cost information"
"errMessage": "Failed to retrieve cost information",
"kubeCostError": "Cost information is temporarily unavailable"
}
},
"common": {
Expand Down
3 changes: 2 additions & 1 deletion frontend/jupyter/src/assets/i18n/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@
"gpus": "GPUs",
"storage": "Stockage",
"total": "Total",
"errMessage": "Échec de la récupération des informations des coûts."
"errMessage": "Échec de la récupération des informations des coûts.",
"kubeCostError": "Les informations sur les coûts sont temporairement non disponible"
}
},
"common": {
Expand Down