Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve spacing for new data volume config #29

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix: Improve spacing for new data volume config #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/app/resource-form/form-data-volumes/form-data-volumes.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ <h3>
<mat-icon>add</mat-icon>ADD VOLUME
</button>

<div *ngFor="let vol of datavols; let i = index" class="volume-wrapper">
<div *ngFor="let vol of datavols; let i = index" class="delible-volume">
<app-volume
[volume]="vol"
[notebookName]="parentForm.get('name').value"
Expand Down
8 changes: 3 additions & 5 deletions frontend/src/app/resource-form/form-data-volumes/form-data-volumes.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
// Data Volumes with the Delete button
.volume-wrapper {
.delible-volume {
display: flex;
width: 100%;
}

.volume-wrapper > app-volume {
flex: 1 1 0px;
.delible-volume > app-volume {
min-width: initial;
max-width: 93%;
}

.volume-wrapper > .del-btn {
flex: 1 1 0px;
.delible-volume > .del-btn {
margin-top: 0.8rem;
margin-left: 1.5rem;
width: 7%;
Expand Down
8 changes: 6 additions & 2 deletions frontend/src/app/resource-form/volume/volume.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,16 @@

.volume-wrapper {
display: flex;
margin-left: -0.5rem;
margin-right: -0.5rem;
}

.volume-wrapper > * {
flex: 1 1 0px;
padding-right: 0.5rem;
padding-left: 0.5rem;
}
.volume-wrapper > *:first-child {
padding-left: 0;
}
.volume-wrapper > *:last-child {
padding-right: 0;
}