Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add validation for mounted pvc #51

Merged
merged 2 commits into from
Jan 7, 2021
Merged

feat: Add validation for mounted pvc #51

merged 2 commits into from
Jan 7, 2021

Conversation

wg102
Copy link
Contributor

@wg102 wg102 commented Jan 4, 2021

Resolves #50

@wg102 wg102 marked this pull request as ready for review January 4, 2021 20:11
@ca-scribner ca-scribner requested a review from saffaalvi January 6, 2021 16:13
@ca-scribner
Copy link
Contributor

This is a nice to have but not urgent. Suggest we wait for Saffa to return and get her to review rather than Brendan/Will?

@saffaalvi saffaalvi merged commit 8641aab into master Jan 7, 2021
@wg102 wg102 deleted the 50-add-validation-mounted-pvc branch January 11, 2021 15:54
saffaalvi added a commit that referenced this pull request Feb 11, 2021
@saffaalvi
Merge pull request #51 from StatCan/50-add-validation-mounted-pvc
537e26b 
feat: Add validation for mounted pvc
@wg102 wg102 mentioned this pull request Sep 12, 2022
Closed
15 tasks
@mathis-marcotte mathis-marcotte mentioned this pull request Sep 21, 2022
Closed
@Jose-Matsuda Jose-Matsuda mentioned this pull request Sep 23, 2022
Merged
Jose-Matsuda added a commit that referenced this pull request Oct 3, 2022
@Jose-Matsuda
Validation fix (#144)
f72afcd 
* This adds back our custom changes introduced in #19, #51, #61. All changes have been noted with some comments to make this easier when we do it again next time.

* PLEASE NOTE. There are NO translations and there is test text. 

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saffaalvi saffaalvi saffaalvi approved these changes

Assignees

@brendangadd brendangadd

@saffaalvi saffaalvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate notebook server PVCs on server creation
4 participants
@wg102 @ca-scribner @saffaalvi @brendangadd