Skip to content

Commit

Permalink
rebase: central-dashboard v1.6.0 (#111)
Browse files Browse the repository at this point in the history
* releasing: Add WG-Notebooks leads to release owners (#5777)

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Specify commonLabels for tensorboard-controller (#5780)

* Remove jlewi as an approver (#5786)

Removing myself as an owner. This should lead to better auto-assignment of code reviews.

* Update notebook server base images (#5804)

* Update second layer docker images to new tags and some python deps (#5809)

* Update image tags and python packages in pytorch and tensorflow full dockerfiles (#5817)

* Add CI format checks for the Jupyter web app (#5811)

* jwa(front): Add npm rule for checking the format

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci: Add common tasks for format checks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(jwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Fix formatting

Run `npm run format:write` on frontend

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Include prettier in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Don't copy node_modules in Dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps: Add global dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa: Remove unused dockerignore file

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(make): Don't include dockerignore and cleanup

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* initial notebook server images README.md (#5818)

* tensorboard-controller: Fix scheduling unbound PVCs (#5819)

When the TB controller attempts to schedule a RWO PVC it checks its
accessModes in the PVC status. The controller panics if the list is
empty.

This commit adds a check to ensure the list is not empty.

Signed-off-by: Ilias Katsakioris <elikatsis@arrikto.com>

* Fix profile-controller CRD pruning issue (#5822)

* api: Add marker for preserving unknown fields in Plugins

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* manifests: Regenerate manifests

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Remove Logo Trademarks from the Jupyter Web App and make logos configurable (#5823)

* rebase: Make logos configurable in configmap and remove trademark references

Rebased to remove the changes to the package-lock.json

* review: add suggested changes and add image group section to README

* Make notebook limits configurable with a multiplication factor (#5815)

* Make notebook limits configurable with a multiplication factor

* Make limits configurable under advanced section

* run prettier to format frontend code

* fix formatting and add rounding in backend

* Return error if limit is smaller than request

* Allow disabling limitFactor by setting it to none

* review: remove camelCase in python backend

* fix: update spawner_ui_config.yaml in manifests directory

* review: fix setting limits backend

* review: remove unnecessary check from backend

* notebook-servers: Update JupyterLab and add Git Extension (#5846)

* chore: Add comment to reference RStudio license. (#5884)

* CI/CD: add kustomize build tests (#5919)

* Add CI format checks for the Volumes web app (#5820)

* vwa(front): Add npm script to check the formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Update the package-lock.json

Run `npm install` to bring the package-lock.json up to date

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(back): Fix formatting

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Remove unused dockerignore file

We have created a global dockerignore file for all the web apps in the
parent dir.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(docker): Don't copy node_modules in dockerfile

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(make): Don't include dockerignore

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* ci(vwa): Add format check tasks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(docker): Copy only necessary files for build

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: Use docker context instead of cd ..

Don't use a `cd ..` and copy dockerignore files back and forth. Instead
we should use the Docker context and the global dockerignore file we
have for all the web apps.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* tensorboard-controller: fix binding issue (#5925)

* JWA: Don't override assets with logos ConfigMap (#5942)

* jwa(front): Add static logos in the app

The app does not contain the logos' svgs in its source code/static
files. This results in the icons to not show when developing locally.

This commit adds the svgs found in the logos ConfigMap to the static
files of the app as well.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Change logos fetch url

Change the URLs of the logos from `static/assets/*` to
`static/assets/logos`.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(manifests): Don't override assets with logos

Mount the ConfigMap under the `static/assets/logos` directory to not
override the contents of the entire assets dir.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Make it possible to add Namespaced menu items (#5871)

* Make it possible to add Namespaced menu items

* Reduce the nesting levels

* FIX The number of gpu must be set as string in Kubernetes/Openshift (#5891)

* Update form.py

* Update form.py

* Update form-default.component.ts

* fix whitespace issue

* feat(jupyter): add fonts as assets to service (#5691)

* cwa(front): Ignore font files in assets

* feat(jupyter): add fonts as assets to service

* CRUD: fonts in common

* CWA: Remove link to css file

* jwa(front): Remove font assets from jupyter

Co-authored-by: Wendy Gaultier <wvgaultier@gmail.com>

* Update base notebook for Renovate compatibility (#5955)

* Update base notebook for Renovate compatibility

* Separate kubectl and S6 arch

* Update jupyter, rstudio and vs code notebook images + allow rstudio in iframe (#5961)

* Update jupyter, rstudio and vs code notebook images

* Remove sed and use substring removal

* Make menu bar scrollable again (#5964)

* [fix]: Make jupyter-web-app parse workspace volume MountPath (#5952)

* [fix]: Make jupyter-web-app parse workspace volume MountPath

- workspace volume path was fixed with "/home/jovyan"
- it should be enable to parse from jupyter-web-app-config's data

* change parsing key correctly

* Remove the f-strings in the Jupyter web app's backend (#5680)

* Notebook servers: Add explanation about kernel not connecting (#5920)

* fix(profile-controller): KNative probes (#5848)

Knative control-plane components need to probe certain paths of Knative
Pods, in order to function correctly. These paths are:
- /healthz
- /metrics
- /ready
- /wait-for-drain

For this reason, we extend the Profile Controller to apply an Istio
AuthorizationPolicy that allows traffic to these HTTP paths for Pods in
user namespaces, as per Knative's instructions:
https://knative.dev/docs/serving/istio-authorization/#allowing-access-from-system-pods-by-paths

This only fixes requests through the public ingress. Cluster-internal
traffic and predictor-transformer use-cases are not supported yet. We
continue discussing these in kubeflow#5965.

Refs kubeflow#5965
Refs kubeflow/kfserving#1558

Signed-off-by: Yurii Komar <subreptivus@gmail.com>

* feat(jupyter): Support hiding image registry/tag (#5681)

* feat(jupyter): Support hiding image registry/tag

* feat(jupyter): Support hiding VSCode/RStudio images registry/tag

* rebasing onto upstream master

* fix: formatting with prettier and set default hideRegistry=true

* fix: move hideRegistry and hideTag from spawnerFormDefaults.image

* fix whitespace

* add tooltip for images

Co-authored-by: JessicaBarh <jessicabarhoma@gmail.com>

* Update dockerfiles and make compatible with Renovate (#5968)

* Update dockerfiles and make compatible with Renovate

* Set memory for jupyter pytorch to the same as jupyter tensorflow

* Update protobuf

* Remove conda version and use substring expansion

* Update SQLAlchemy

* Update dill

* Create OWNERS file in .github folder for Renovate config + workflows (#5983)

* Extend deadline for PyTorch image building (#5991)

* Allow user to add/delete labels to user namespace using ConfigMap. Fix #5712 (#5761)

The profile-controller applies a hardcoded list of labels to Profile
namespaces. Make this list of labels configurable with a ConfigMap. The
new list of steps for the profile-controller is:

1. **(new)** Profile-controller starts and reads the file given by the
   `--namespace-labels-path` CLI flag (defaults to
   `/etc/profile-controller/namespace-labels.yaml`). This file contains
   a YAML dict of label key/values to add to each Profile namespace.
2. Profile-controller creates namespace.
3. Profile-controller merges existing namespace labels with given
   labels. A given label is applied ONLY if it doesn't exist already.
4. **(new)** If a given label value is empty (``), remove the label from
   the namespace if it already exists.

We are using a ConfigMap instead of a plain CLI flag, so that users can
change the list of labels without restarting the profile-controller.

Closes #5712

Signed-off-by: Yannis Zarkadas <yanniszark@arrikto.com>

Co-authored-by: James Liu <jamxl@google.com>

Co-authored-by: Yannis Zarkadas <yanniszark@arrikto.com>

* Update last batch of notebook server Dockerfiles (#5997)

* Update spawner_ui_config.yaml with new tags (#5998)

* Update images in spawner_ui_config.yaml

* Update manifest image tags

* CRUD web apps:  i18n (#5880)

* feat(jupyter): add modules for translations

* feat(jupyter): fix path for translations + add GPU translations

* feat(jupyter): add translations

* feat(jupyter): add translations to form-default

* feat(jupyter): add translations to affinity/tolerations

* feat(jupyter): add translations to Image Pull Policy

* feat(jupyter): remove imports from app.module.ts + fix translations

* web-apps(front): add TranslationModule to common for jupyter

* Implement i18n for jupyter frontend
- Including common components needed
- Refactor translation file

* web-apps(front): add i18n to messages from backend
Status tooltip text
Snackbar message

* web-apps(front): volumes and tensorboards i18n ini
Add the i18n feature for the other 2 projects

* feat(volume): add translations for volume

* feat(jupyter): refactor asset file

* Update asset files for all folders

* feat(tensorboards): add i18n
Update all asset files

* cwa: add new translations

* cwa: Add README documentation

* fix: formatting with prettier

* Fix tests

* Fix python format

* remove comment

Co-authored-by: saffaalvi <alvi118@uwindsor.ca>
Co-authored-by: Jose-Matsuda <tongster789@gmail.com>

* Remove deprecated JWA (#5959)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Sync spawner yaml from source to manifests (#5999)

* notebooks: Add additional PGP server for RStudio package validation (#6010)

* Change PGP server for RStudio validation to pgp.surfnet.nl

* Add as secondary keyserver

* Add support for ServiceAccountName and AutomountServiceAccountName to admission-webhook (#5939)

* WA: Use relative paths for fetching translation files (#6034)

* jwa(front): Use relative path for i18n json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Use relative path for i18n json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Use relative path for i18n json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update CRUD web apps from Angular 8 to Angular 12 (#6004)

* common: update angular core and cli to 9

ng update @angular/core@9 @angular/cli@9

* common: update material, cdk and cdk-experimental to 9

ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9

* common: remove entryComponents and replace TestBed.get with TestBed.inject

Edit files manually

* common: make compatible with Angular 9

Edit files manually

* common: update fontawesome to 0.6.0

npm i @fortawesome/angular-fontawesome@0.6.0

* update kubeflow-common project dependencies

* common: add @angular/localize

ng add @angular/localize

* jupyter: update angular core and cli 8

ng update @angular/core@8 @angular/cli@8

* jupyter: update angular core and cli to 9

ng update @angular/core@9 @angular/cli@9

* jupyter: update material, cdk and cdk-experimental to 9

ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9

* jupyter: remove entryComponents

Edit file manually

* jupyter: update fontawesome to 0.6.0

npm i @fortawesome/angular-fontawesome@0.6.0

* jupyter: add @angular/localize

ng add @angular/localize

* tensorboards: update angular core and cli to 9

ng update @angular/core@9 @angular/cli@9

* tensorboards: update material, cdk and cdk-experimental to 9

ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9

* tensorboards: remove entryComponents and replace TestBed.get with TestBed.inje…

Edit files manually

* tensorboards: update fontawesome to 0.6.0

npm i @fortawesome/angular-fontawesome@0.6.0

* tensorboards: add @angular/localize

ng add @angular/localize

* Fix tensorboards-web-app run-dev in makefile

Edit file manually

* volumes: update angular core and cli to 9

ng update @angular/core@9 @angular/cli@9

* volumes: update material, cdk and cdk-experimental to 9

ng update @angular/cdk@9 @angular/material@9 @angular/cdk-experimental@9

* volumes: remove entryComponents and replace TestBed.get with TestBe…

Edit files manually

* volumes: update fontawesome to 0.6.0

npm i @fortawesome/angular-fontawesome@0.6.0

* volumes: add @angular/localize

ng add @angular/localize

* common: update angular core and cli to 10

ng update @angular/core@10 @angular/cli@10 --force

* common: update material, cdk and cdk-experimental to 10

ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10

* update kubeflow-common project dependencies

Edit file manually

* common: update fontawesome to 0.7.0

npm i @fortawesome/angular-fontawesome@0.7.0

* common: fix font location

Edit file manually

* jupyter: update angular-fontawesome to 0.7.0

npm i @fortawesome/angular-fontawesome@0.7.0

* jupyter: update angular core and cli to 10

ng update @angular/core@10 @angular/cli@10

* jupyter: update material, cdk and cdk-experimental to 10

ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10

* tensorboards: update angular-fontawesome to 0.7.0

npm i @fortawesome/angular-fontawesome@0.7.0

* tensorboards: update angular core and cli to 10

ng update @angular/core@10 @angular/cli@10

* tensorboards: update material, cdk and cdk-experimental to 10

ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10

* volumes: update angular-fontawesome to 0.7.0

npm i @fortawesome/angular-fontawesome@0.7.0

* volumes: update angular core and cli to 10

ng update @angular/core@10 @angular/cli@10

* volumes: update material, cdk and cdk-experimental to 10

ng update @angular/cdk@10 @angular/material@10 @angular/cdk-experimental@10

* common: update angular-fontawesome to 0.8.2

npm i @fortawesome/angular-fontawesome@0.8.2

* common: update codelyzer to 6.0.2

npm i codelyzer@6.0.2

* common: install @angular-devkit/core@11

npm install --save-dev @angular-devkit/core@11

* common: update angular core and cli to 11

ng update @angular/core@11 @angular/cli@11

* common: update material, cdk and cdk-experimental to 11

ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11

* update kubeflow-common project dependencies

Edit file manually

* jupyter: update angular-fontawesome to 0.8.2

npm i @fortawesome/angular-fontawesome@0.8.2

* jupyter: update codelyzer to 6.0.2

npm i codelyzer@6.0.2

* jupyter: update angular core and cli to 11

ng update @angular/core@11 @angular/cli@11

* jupyter: update material, cdk and cdk-experimental to 11

ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11

* tensorboards: update angular-fontawesome to 0.8.2

npm i @fortawesome/angular-fontawesome@0.8.2

* tensorboards: update codelyzer to 6.0.2

npm i codelyzer@6.0.2

* tensorboards: update angular core and cli to 11

ng update @angular/core@11 @angular/cli@11

* tensorboards: update material, cdk and cdk-experimental to 11

ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11

* volumes: update angular-fontawesome to 0.8.2

npm i @fortawesome/angular-fontawesome@0.8.2

* volumes: update codelyzer to 6.0.2

npm i codelyzer@6.0.2

* volumes: update angular core and cli to 11

ng update @angular/core@11 @angular/cli@11

* volumes: update material, cdk and cdk-experimental to 11

ng update @angular/cdk@11 @angular/material@11 @angular/cdk-experimental@11

* common: Fix CI failure

* jupyter: npm run format:write

npm run format:write

* volumes: npm run format:write

npm run format:write

* tensorboards: manually run prettier

prettier --write 'src/**/*.{js,ts,html,scss,css}'

* common: Fix MockComponent entryComponents for CI

Manually edit file

* common: update angular-fontawesome to 0.9.0

npm i @fortawesome/angular-fontawesome@0.9.0

* common: update angular core and cli to 12

ng update @angular/core@12 @angular/cli@12

* common: update material, cdk and cdk-experimental to 12

ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12

* update kubeflow-common project dependencies

Edit file manually

* common: fix Intl.DateTimeFormatOptions

Edit file manually. Type of defaultDateOptions and defaultTimeOptions needs to explicitly be set to Intl.DateTimeFormatOptions.

* jupyter: update angular-fontawesome to 0.9.0

npm i @fortawesome/angular-fontawesome@0.9.0

* jupyter: update codelyzer to 6.0.2

npm i codelyzer@6.0.2

* jupyter: update angular core and cli to 12

ng update @angular/core@12 @angular/cli@12

* jupyter: update material, cdk and cdk-experimental to 12

ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12

* tensorboards: update angular-fontawesome to 0.9.0

npm i @fortawesome/angular-fontawesome@0.9.0

* tensorboards: update angular core and cli to 12

ng update @angular/core@12 @angular/cli@12

* tensorboards: update material, cdk and cdk-experimental to 12

ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12

* volumes: update angular-fontawesome to 0.9.0

npm i @fortawesome/angular-fontawesome@0.9.0

* volumes: update angular core and cli to 12

ng update @angular/core@12 @angular/cli@12

* volumes: update material, cdk and cdk-experimental to 12

ng update @angular/cdk@12 @angular/material@12 @angular/cdk-experimental@12

* common: update and audit packages

npm update && npm audit fix && npm i lodash-es@4.17.21 && npm i material-icons@0.7.3

* jupyter: update and audit packages

npm update && npm audit fix && npm i material-icons@0.7.3

* tensorboards: update and audit packages

npm update && npm audit fix && npm i material-icons@0.7.3

* volumes: update and audit packages

npm update && npm audit fix && npm i material-icons@0.7.3

* jupyter: npm run format:write

npm run format:write

* lists roadmap in reverse chronological order (#6055)

Signed-off-by: Malini Bhandaru <mbhandaru@vmware.com>

* Correct missing predicates in controller watches. Fixes #5326 (#5873)

Co-authored-by: Filinto Duran <fduran@d2iq.com>

* fix(web-apps): Use Angular's i18n proposed implementation (#6065)

* jwa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormImage

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormAdvancedOptions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormAffinityTolerations

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormConfigurations

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormCpuRam

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormDataVolumes

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormGpus

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FromName

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n FormWorkspaceVolume

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Volume

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Add localize to peerDependencies

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Import $localize in library

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n RokService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n ConfirmDialog

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n ResourceTable

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n SnackBar

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-app(front): i18n NameNamespaceSelector

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Remove ngx-translate

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(back): Don't parse keys in status

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(back): Revert backend messages

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(back): Don't parse keys in status

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): i18n Form

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* vwa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(back): Revert backend messages

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Add i18n rules in package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Add i18n for french in angular.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n Index

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n BackendService

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): i18n App

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Update translation language files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa(front): Remove ngx-translate from package.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa: Update READMEs

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* web-apps(front): Add localize when testing

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* [CentralDashboard] Add entry for Models web app (#6085)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Interact with the namespace selector (#5995)

* Interact with the namespace selector

* Use namespace given as an argument

* Keep the index of selected item

* fix(jwa): Fix limits calculation when limitFactor is none (#6058)

* jwa(front): Don't allow NaN values in limits

The UI should always catch a NaN value and don't add it in the form.
Currently this is the case for the cpu/memory limits.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Limits should not be changed if dirty

If the user has manually edited the limits fields then the UI should not
try to automatically calculate them again, using the limitFactors.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Fix NaN in Kubeflow Notebooks (#6092)

* Fix NaN in Kubeflow Notebooks

* add a validation check for NaN values

* fix: validation check if value is None

* lint: fix line length

* add section for 1.4; small updates for 1.3 section (#6082)

* add section for 1.4; small updates for 1.3 section

* refer to training operators consistently; add link to Notebooks roadmap.

* address @Bobgy feedback regarding Kubeflow Pipelines portions of 1.4 roadmap

* Remove virtualservice timeout to prevent websocket disconnect (#6126)

In the existing version, the 'timeout: 300s' added to the notebook's virtual service would cause websockets to disconnect at the 5 minute mark, causing the Jupyter Notebook web terminal function to hang. This is described in https://github.com/kubeflow/kubeflow/issues/6124.

* fix(admission-webhook): attach namespace to pod request if pod does not have it (#6052)

* fix(admission-webhook): attach namespace to pod request if pod does not have it

* Apply suggestions from code review

Add more explicit logs

Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>

* Add more explicit log

Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>

Co-authored-by: Erhan Kesken <ekesken@users.noreply.github.com>

* Fix notebook base image gpg keys (#6138)

* update links for new testing infra (#6144)

* Add more root OWNERS (#6146)

* Improve README for example-notebook-servers (#6165)

* jwa(front): Don't disable vendors with no GPUs (#6171)

JWA should not block users from selecting GPUs if the current cluster
nodes do not have any GPUs attached to them. We've seen users that have
autoscaled nodegroups for GPUs, so a GPU node will be added to the
cluster once a Pod has requested it.

Refs: arrikto/dev#1484

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Bump Golang version in PodDefaults, TensorBoard Controller and KFAM to 1.17 (#6180)

* kfam: Upgrade go to 1.17

Update to a more recent docker image that has a newer version of
openssl.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* poddefaults: Upgrade go to 1.17

Update to a more recent docker image that has a newer version of
openssl.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* tensorboards: Upgrade go to 1.17

Update to a more recent docker image that has a newer version of
openssl.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Update Notebooks README regarding custom packages (#6176)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Fix reference to PodPreset as PodDefault (#6184)

* fix: tensorboard-controller is killed due to out of memory (#6148)

* Update manager.yaml

* Update manager.yaml

* fix(web-apps): Use relative path for --deploy-url build. #5566 (#6206)

* fix(web-apps): Use relative path for --base-href build

* volume web app should use volume base-href

* Document for cutting Kubeflow website release. (#6198)

* Document for cutting Kubeflow website release.

* Update docs_dev/releasing.md

Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>

* Update docs_dev/releasing.md

Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>

* address comment

* canonical name

Co-authored-by: Shannon Bradshaw <shannon.bradshaw@arrikto.com>

* Change namespace label for Katib metrics collector injection (#6225)

* fix(backend): tensorboard-controller does not work because of missing permissions (#6216)

* add(web-apps): i18n Fr translations (#6122)

* chore(docs): It's better to refer to the cli documents, not repo's readme (#6239)

* fix(docs): Fix the 404 K8s docs link (#6236)

* nit: typo in README.md (#6211)

* web-apps(front) : change error msg for min (#6193)

* Centraldashboard/add uncaughtexception handler (#6203)

* Central dashboard - Add global uncaught exception handler

* fix comments

* Fix(frontend): Upgrade ts node to v4 (#6242)

* Upgrade ts-node to v10

* Update lock

* admission-webhook-manifests: Update the cert manager from v1alpha2 to v1 (#6230)

* Short term updates to Published Kubeflow Roadmap (#6248)

3 changes - Add info on Kubeflow 1.5 and 1.4.1.   Update roadmap to show that Kubeflow 1.4 was delivered.

* Upgrade the google cloud monitoring node.js client (#6210)

* Upgrade the google cloud monitoring node.js client

* Update package-lock.json

* Upgrade TypeScript to v4

* Update package-lock.json

* run tslint

* fix dashboard sending malformed headers to kfam (#6186)

* correct typo - track to tracked (#6264)

corrected typo "track" to "tracked"

* centraldashboard: Update node and use latest-stable (#6260)

Change the tests to NOT fetch Chromium from the Edge branch, which is develop,
but instead use latest-stable. We saw that edge can have problems from times to
times.

In the same commit we also update the node version to fix CVEs with the current
v12.18.3 version that we had.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Tell user to select a namespace to access namespaced menu item (#6181)

* Fix unnecessary updates of istio AuthorizationPolicy (#6269)

* Introduce a basic proposals flow for more advanced features (#6272)

* Introduce a proposals dir for Notebooks

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Move the proposals dir under components

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Secure access to KFAM (#6077)

* fix(notebooks) make culling work with multi-user (#5128) (#5980)

* JWA: Very basic E2E tests to run locally (#6005)

* web-apps(front): Add test attrs selectors

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Update gitignore for cypress files

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Install cypress & npm scripts for e2e

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(e2e): Add first cypress tests

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa: Update the README for e2e instructions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* chore: remove Bobgy from OWNERS

* frontend: Use responsive tables instead of cards (#6316)

* jwa(front): Make ng lint work by ignoring e2e/tsconfig.json

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* web-apps(front): Make the table responsive

We introduced all of our changes in the underlying TableComponent. This
component can then be either used independently or inside a material
card.

The changes we did in that component are:
1. Create Output() emitters, since this component can be used directly
2. The config object for a Table row now supports a `style` prop for
   defining the list of CSS styles to be applied
2. Remove the truncate classes (small, medium, large) and only have
   a boolean value. The user can define the width directly now via the
   `style` property in the row's config
3. Modify the classes for aligning contents right and left

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* web-apps(front): Add table paginator

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* web-apps(front): Add padding to titlebar text

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* web-apps(front): Use bigger font for toolbar title

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Use responsive table and toolbar

We refactor both the index and form pages of the app to:
1. Add a top row toolbar with the title of the app and the button to
   create a new Notebook
2. Replace the card with a responsive table that shows the items. The
   component also has a paginator

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* vwa(front): Use responsive table and toolbar

This commit:
1. Adds a toolbar at the top of the index page with the title of the app
   and the button to create a new volume
2. Replaces the card with a responsive table

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* twa(front): Use responsive table and toolbar

This commit:
1. Adds a toolbar at the top of the index page with the title of the app
   and a button to create a new TensorBoard instance
2. Replaces the card with a resopnsive table

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* fix the format

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* wa(front): Add npm script for running unit tests in docker

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* fix unit tests failing

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Don't use asterisk in Dockerfiles (#6318)

* wa(docker): Don't copy node_modules

To ensure Kaniko is not copying stale node_moduels folders, even though
we have a dockerignore file, we are explicitly only copying the source
code.

We have seen the build system with Kaniko to fail, due to NFS stale
instances with files in node_modules and expect that this is the root
cause.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* twa: Update makefile to use global dockerignore

The dockerfile for TWA was copying over the local dockerignore. This was
overriding the global one we had for all the web apps.

This commit updates the Makefile of the app to use the global
dockerignore that all the apps should use.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6309)

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 7.0.16 to 7.0.39 in /components/centraldashboard (#6308)

Bumps [postcss](https://github.com/postcss/postcss) from 7.0.16 to 7.0.39.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/7.0.39/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/7.0.16...7.0.39)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/tensorboards/frontend (#6311)

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/volumes/frontend (#6310)

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump log4js from 6.3.0 to 6.4.1 in /components/crud-web-apps/jupyter/frontend (#6312)

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update images for the 1.5 rc0 release (#6319)

* Update the releasing version tag

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Run automated script for updating versions

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* Fix(manifests): Upgrade rbac.authorization.k8s.io from v1beta1 to v1 (#6261)

* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6295)

* proposal: Extend Notebook Controller to expose idleness for Jupyter (#6270)

Provide a design doc as a proposal for extending Notebook Controller to
expose idleness for Jupyter. Our proposal is in markdown format and follows
the guidelines of the kubeflow/components/proposal/README.md guide.

You can view the #6270 issue in the following link:
https://github.com/kubeflow/kubeflow/issues/6270

Signed-off-by: Athanasios Markou <athamark@arrikto.com>

* review: change the title of the proposal

Change the title of the proposal to only include the
proposed new feature. The new title of the proposal
will now be "Expose Idleness Information for Jupyter
Notebooks".

* review: rename the proposal markdown file

We want to give a more specific name to the markdown
which contains the proposal. Since this proposal
emphasizes on a feature regarding the Jupyter Notebooks,
the new name will be:

20220121-jupyter-notebook-idleness.md

* Synchronize jupyter-web-application role with clusterrole (#6241)

* Update role.yaml

* Update role.yaml

* Update cluster-role.yaml

* Kubeflow Roadmap update - with 1.5 details (#6266)

* Kubeflow Roadmap update - with 1.5 details

These proposed changes include: identifying that 1.4.1 has been delivered, provides themes for 1.5 and provides details of major features in 1.5 by working group.   This is an initial proposal that needs review by the working group leads.

* correct formatting in KFP features

Moved KFP features under KFP Control Flow doc

* updating KFP section

updating KFP references with updates from KFP team

* Updated the 1.5 release date to March

updated the 1.5 release date to March

* Update ROADMAP.md

change Hyperparameter leader election to Katib leader election

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update ROADMAP.md

improve description and details of feature for metrics collector

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Update Katib description for Early stopping in 1.5

updating with Andrey's suggestion (but without the world proper).   * Validation for Early Stopping algorithm settings helps users to proper reduce model overfitting

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* notebooks: Extend Notebook Controller to expose idleness for Jupyter (#6297)

* notebooks: Update image's tag in make

Modify Makefile to update properly the TAG
based on the git TAG.

Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Expose last-activity

Extend the notebook-controller to:
* cull idle Notebook Servers based on their new `last-activity`
  annotation
* expose the last activity of each Notebook Server as an annotation
  on the metadata of the corresponding CR object

Modify notebook_controller.go to:
* update the Last Activity of each Notebook Server that has a
  Running pod
* delete the Last Activity Annotation for every Notebook Server
  that does not have a Running pod

Extend culler.go to:
* perform culling based on the new `last-activity` annotation and
  not based on the `/api/status` endpoint.
* update the last activity of a Notebook Server, based on the
  kernels' execution states.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Athanasios Markou <athamark@arrikto.com>

* notebooks: Introduce a DEV env var

We introduce a DEV ENV var to allow admins
develop and test on their local machine their
custom Notebook Controller.
We provide information and instructions inside
the components/notebook-controller/README.md.

Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Add unit tests for last-activity

* Introduce new tests for allKernelsAreIdle()
* Extend the tests for NotebookIsIdle() and for
  NotebookNeedsCulling().

Signed-off-by: Athanasios Markou <athamark@arrikto.com>
Reviewed-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* review: UpdateNotebookLastActivityAnnotation()

Ensure that UpdateNotebookLastActivityAnnotation() does not return
"true". This function should not return any value.

Signed-off-by: Athanasios Markou <athamark@arrikto.com>

* jwa: Rework the Storage API of the web app (#6321)

* wa(back): Add helper for deserializing JSON obj

In some cases we might need to construct Python k8s lib objects from the
JSONs that are provided by clients. I.e. the UI will be sending a PVC
object in json format, so the backend will need to create the
corresponding client.V1PersistentVolumeClaim object and submit it.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* wa(back): Serialization helper

Add helper function for converting a k8s-client object into a dict that
can be sent as an HTTP response.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* wa(back): Add dry run to Notebooks and PVCs

The backend will need to be able to create objects with dry-run, in
order to ensure they are valid. The backend will need to check that both
the Notebook and the PVCs can be created beforehand.

This way we avoid the scenario where we create PVCs but the Notebook
fails to be created, and the PVCs are never garbage collected.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* wa(back): Update kubernetes to 0.17

In order to support dry-run we must use the 0.17 version of the Python
k8s client.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* wa(back): Extend api module to patch pvcs

The backend will need to be able to PATCH PVCs in order to set the
ownerReference to the Notebook that mounts the PVCs.

Ref: arrikto/dev/issues/386#issuecomment-856700392

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* jwa(back): Work with new Volumes API

The backend API should not add any more layers of abstractions on top of
the K8s API. The backend should expect the client/UI to be sending the
entire PVC spec of a new PVC.

Refs: arrikto/dev/issues/386

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* jwa(back): Add unittests for new volumes API

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* jwa(back): Extend the PVC info returned

We want to show both the access mode and size of the existing PVCs, when
a user clicks on the dropdown to select which PVC to mount.

The backend will need to provide this information to the frontend. We
don't want to send the K8s list of PVCs since this will result in a lot
of unnecessary data to be sent.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Ilias Katsakioris <elikatsis@arrikto.com>

* jwa(front): Add proxy config for Rok

When developing the Rok flavor locally we will need to be able to open
the Rok chooser. This can be done by using Angular/webpack proxy to
bring the exposed rok service and the app under the same domain.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Remove card from form

The form of the app should not be a big card, but a normal form.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Install AceModule for yaml editing

Install AceModule to allow users to edit yamls of objects.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* wa(front): Change the styling of form sections

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Create common volume components

Component for:
* New PVC and configuring its spec
* Attaching an existing PVC in a Notebook

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Update Rok form for new Volume API

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa(front): Mark inputs as dirty when restoring Lab

When the UI autofills the form with values from a JupyterLab snapshot
then it should mark the touched fields as dirty. This way if a field has
errors the UI will make that input red.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
Reviewed-by: Tasos Alexiou <tasos@arrikto.com>

* jwa: Update ConfigMap in manifests

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* jwa(front): Fix format errors

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* profiles: Update the permissions for notebook idleness (#6335)

Extend the Profiles Controller to give permissions to Notebooks
controller for making GET requests to notebook's /api/kernels endpoint.

Refs https://github.com/kubeflow/kubeflow/blob/master/components/proposals/20220121-jupyter-notebook-idleness.md

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Graceful handling of events (#6338)

* notebooks: Handle events gracefully

The controller is not exiting the reconciliation loop after it has
re-emitted a Pod/STS Event as a Notebook Event. This results in the
controller to later on try and GET a Notebook with the name of the Event
that triggered the reconciliation loop.

The controller should exit the reconciliation function once it has
emitted the event.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Don't reconcile on deleted events

We don't want to trigger the reconciliation function when an event gets
deleted.

If a Notebook would be deleted then the underlying events would
be deleted as well, which results in the reconcile function to get
triggered and try to GET Events and Notebooks with the name of the
deleted event.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Fix endless restarts (#6341)

* notebooks: Update notebook if timestamp changed

We don't want to be updating the spec of the notebook if the timestamp
hasn't changed, since this will lead to constant updates and
reconciliation loops.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Use a deep-copy of the notebook spec

The controller should use a deep-copy of the notebook spec when
calculating the spec for the StatefulSet. If not then we could
update the notebook object without wanting it, since the spec could have
been changed when calculating the STS spec.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Add prefix env var only if missing

The controller should be setting OR updating the NB_PREFIX env var.
Previously it would always blindly append it to the spec, which could
result in double entries for the same env var.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* releasing: Update tags for v1.5.0-rc.1 (#6343)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* fix error comparison between pointer and pointer in "CopyStatefulSetFields" (#6195)

error comparison between pointer and pointer in "CopyStatefulSetFields"

* [bugfix]: update unsupported links to latest pages (#6192)

* centraldashboard: Add KServe overlay (#6383)

Configure the dashboard to use the KServe app instead of the KFServing
0.6.1 one.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* notebooks: Don't reconcile on Events deletion (#6391)

The controller should not trigger the reconcile loop when an Event is
deleted. Previously the controller would run the reconciliation loop on
any event deletion.

This commit updates it to not run the loop for ANY event.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* releasing: Create v1.5.0-rc.2 images (#6394)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* release: Images for the 1.5.0 tag (#6398)

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>

* added env for app secure cookies (#6395)

* build(deps): bump github.com/gogo/protobuf from 1.1.1 to 1.3.2 in /components/tensorboard-controller (#6424)

Bumps [github.com/gogo/protobuf](https://github.com/gogo/protobuf) from 1.1.1 to 1.3.2.
- [Release notes](https://github.com/gogo/protobuf/releases)
- [Commits](https://github.com/gogo/protobuf/compare/v1.1.1...v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/gogo/protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump notebook from 6.4.0 to 6.4.10 in /components/example-notebook-servers/jupyter (#6431)

Bumps [notebook](http://jupyter.org) from 6.4.0 to 6.4.10.

---
updated-dependencies:
- dependency-name: notebook
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/tensorboards/frontend (#6417)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/jupyter/frontend (#6429)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump follow-redirects from 1.14.1 to 1.14.8 in /components/crud-web-apps/tensorboards/frontend (#6357)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/volumes/frontend (#6358)

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump ajv from 6.10.2 to 6.12.6 in /components/crud-web-apps/jupyter/frontend (#6359)

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.10.2 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.10.2...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump lodash-es from 4.17.11 to 4.17.21 in /components/crud-web-apps/tensorboards/frontend (#6402)

Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.21)

---
updated-dependencies:
- dependency-name: lodash-es
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6416)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump minimist from 1.2.5 to 1.2.6 in /components/crud-web-apps/volumes/frontend (#6423)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump undefsafe from 2.0.2 to 2.0.5 in /components/centraldashboard (#6342)

Bumps [undefsafe](https://github.com/remy/undefsafe) from 2.0.2 to 2.0.5.
- [Release notes](https://github.com/remy/undefsafe/releases)
- [Commits](https://github.com/remy/undefsafe/compare/v2.0.2...v2.0.5)

---
updated-dependencies:
- dependency-name: undefsafe
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6378)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/tensorboards/frontend (#6379)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6386)

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/tensorboards/frontend (#6387)

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump moment from 2.24.0 to 2.29.2 in /components/centraldashboard (#6432)

Bumps [moment](https://github.com/moment/moment) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2)

---
updated-dependencies:
- dependency-name: moment
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump url-parse from 1.5.1 to 1.5.10 in /components/crud-web-apps/volumes/frontend (#6380)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump url-parse from 1.4.7 to 1.5.10 in /components/centraldashboard (#6377)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.4.7...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/volumes/frontend (#6388)

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps-dev): bump karma from 6.3.4 to 6.3.16 in /components/crud-web-apps/jupyter/frontend (#6389)

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump follow-redirects from 1.14.1 to 1.14.9 in /components/crud-web-apps/jupyter/frontend (#6441)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.1 to 1.14.9.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.1...v1.14.9)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump nanoid from 3.1.23 to 3.3.2 in /components/crud-web-apps/common/frontend/kubeflow-common-lib (#6437)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.23 to 3.3.2.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/c…
  • Loading branch information
Show file tree
Hide file tree
Showing 218 changed files with 114,718 additions and 51,016 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build-centraldashboard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ name: component/centraldashboard
on:
push:
branches:
- stc-master
- rohan-test
paths:
- components/centraldashboard/**

pull_request:
types:
- 'opened'
# Environment variables available to all jobs and steps in this workflow
env:
REGISTRY_NAME: k8scc01covidacr
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,3 @@ The Kubeflow community is organized into working groups (WGs) with associated re

## Get Involved
Please refer to the [Community](https://www.kubeflow.org/docs/about/community/) page.

9 changes: 6 additions & 3 deletions ROADMAP.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
# Kubeflow Roadmap

## Kubeflow 1.6 Release, Due: July 2022
* Kubeflow 1.6 [milestones and timelines](https://github.com/kubeflow/community/pull/558)
## Kubeflow 1.7 Release - planning now in process
* Please join the Kubeflow Community Meetings on Tuesdays for updates and for opportunities to contribute.

## Kubeflow 1.6 Release, Delivered: September 2022
* Kubeflow 1.6 [milestones and timelines](https://github.com/kubeflow/community/tree/master/releases/release-1.6)

#### Themes
* Kubernetes 1.22 support
* Kubeflow Pipelines v2 (alpha)

### Major Features from each Working Group (note: Individual WG versions are independent of Kubeflow's)

#### Kubeflow Pipelines
* V2 Preview: Support running pipeline in Argo-agnostic approach
* New DAG visualization based on Pipeline Template and MLMD
* SDK to change from `kfp.v2` to `kfp`
* KFP SDK CLI [design](https://docs.google.com/document/d/1Z79ebKaf3hjyadSRsme1Qo7F-Tqu4qM1cyKuLeu2PgA/edit#heading=h.x9snb54sjlu9)

#### Katib
* Support for Population based training
Expand Down
4 changes: 2 additions & 2 deletions components/access-management/kfam/api_default.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
"k8s.io/client-go/informers"
clientset "k8s.io/client-go/kubernetes"
"k8s.io/client-go/kubernetes/scheme"
"k8s.io/client-go/plugin/pkg/client/auth/gcp"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
"k8s.io/client-go/rest"
"sigs.k8s.io/controller-runtime/pkg/client/config"
)
Expand Down Expand Up @@ -68,7 +68,7 @@ func NewKfamClient(userIdHeader string, userIdPrefix string, clusterAdmin string
return nil, err
}

informerFactory := informers.NewSharedInformerFactory(kubeClient, time.Minute * 60)
informerFactory := informers.NewSharedInformerFactory(kubeClient, time.Minute*60)
roleBindingLister := informerFactory.Rbac().V1().RoleBindings().Lister()
stop := make(chan struct{})
informerFactory.Start(stop)
Expand Down
5 changes: 0 additions & 5 deletions components/access-management/kfam/bindings.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,10 @@ package kfam

import (
"fmt"
"k8s.io/apimachinery/pkg/labels"
v1 "k8s.io/client-go/listers/rbac/v1"
"net/url"
"regexp"
"strings"

"k8s.io/apimachinery/pkg/labels"
v1 "k8s.io/client-go/listers/rbac/v1"

istioSecurity "istio.io/api/security/v1beta1"
istioSecurityClient "istio.io/client-go/pkg/apis/security/v1beta1"
rbacv1 "k8s.io/api/rbac/v1"
Expand Down
36 changes: 33 additions & 3 deletions components/admission-webhook/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,46 @@
IMG ?= admission-webhook
TAG ?= $(shell git describe --tags --always --dirty)

# Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set)
ifeq (,$(shell go env GOBIN))
GOBIN=$(shell go env GOPATH)/bin
else
GOBIN=$(shell go env GOBIN)
endif

generate: controller-gen
$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..."

manifests: controller-gen
$(CONTROLLER_GEN) crd:crdVersions=v1,maxDescLen=0 output:crd:artifacts:config=manifests/base paths="./..."
mv manifests/base/kubeflow.org_poddefaults.yaml manifests/base/crd.yaml

build:
go build -gcflags 'all=-N -l' -o bin/webhook .

docker-build:
docker build -t ${IMG}:${TAG} -f Dockerfile .

docker-push:
docker-push:
docker push ${IMG}:${TAG}

image: docker-build docker-push

docker-push:
docker push ${IMG}:${TAG}
CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
.PHONY: controller-gen
controller-gen: ## Download controller-gen locally if necessary.
$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0)

# go-get-tool will 'go get' any package $2 and install it to $1.
PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
define go-get-tool
@[ -f $(1) ] || { \
set -e ;\
TMP_DIR=$$(mktemp -d) ;\
cd $$TMP_DIR ;\
go mod init tmp ;\
echo "Downloading $(2)" ;\
GOBIN=$(PROJECT_DIR)/bin go get $(2) ;\
rm -rf $$TMP_DIR ;\
}
endef
14 changes: 14 additions & 0 deletions components/admission-webhook/hack/boilerplate.go.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
/*

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
86 changes: 84 additions & 2 deletions components/admission-webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ import (
)

const (
annotationPrefix = "poddefault.admission.kubeflow.org"
annotationPrefix = "poddefault.admission.kubeflow.org"
istioProxyContainerName = "istio-proxy"
)

// Config contains the server (the webhook) cert and key.
Expand Down Expand Up @@ -108,6 +109,12 @@ func safeToApplyPodDefaultsOnPod(pod *corev1.Pod, podDefaults []*settingsapi.Pod
errs = append(errs, err)
}

// imagePullSecrets attribute is defined at the Pod level, so determine if volumes
// injection is causing any conflict.
if _, err := mergeImagePullSecrets(pod.Spec.ImagePullSecrets, podDefaults); err != nil {
errs = append(errs, err)
}

for _, ctr := range pod.Spec.Containers {
if err := safeToApplyPodDefaultsOnContainer(&ctr, podDefaults); err != nil {
errs = append(errs, err)
Expand Down Expand Up @@ -147,6 +154,53 @@ func safeToApplyPodDefaultsOnContainer(ctr *corev1.Container, podDefaults []*set
return utilerrors.NewAggregate(errs)
}

// mergeImagePullSecrets merges a list of imagePullSecrets with the imagePullSecrets injected by given list podDefaults.
// It returns an error if it detects any conflict during the merge.
func mergeImagePullSecrets(
imagePullSecrets []corev1.LocalObjectReference,
podDefaults []*settingsapi.PodDefault) ([]corev1.LocalObjectReference, error) {

var errs []error

origMap := map[string]corev1.LocalObjectReference{}
for _, ips := range imagePullSecrets {
origMap[ips.Name] = ips
}

merged := make([]corev1.LocalObjectReference, len(imagePullSecrets))
copy(merged, imagePullSecrets)

for _, pd := range podDefaults {
for _, ips := range pd.Spec.ImagePullSecrets {
found, ok := origMap[ips.Name]
if !ok {
// if we don't have it already, append it and continue
origMap[ips.Name] = ips
merged = append(merged, ips)
continue
}

// make sure they are identical or throw an error
if !reflect.DeepEqual(found, ips) {
errs = append(
errs,
fmt.Errorf(
"merging imagePullSecret for %s has a conflict on %s: \n%#v\ndoes not match\n%#v\n in container",
pd.GetName(), ips.Name, ips, found),
)
}
}
}

err := utilerrors.NewAggregate(errs)
if err != nil {
klog.Error(err)
return nil, err
}

return merged, err
}

// mergeEnv merges a list of env vars with the env vars injected by given list podDefaults.
// It returns an error if it detects any conflict during the merge.
func mergeEnv(envVars []corev1.EnvVar, podDefaults []*settingsapi.PodDefault) ([]corev1.EnvVar, error) {
Expand Down Expand Up @@ -384,6 +438,12 @@ func applyPodDefaultsOnPod(pod *corev1.Pod, podDefaults []*settingsapi.PodDefaul
}
pod.Spec.Tolerations = tolerations

imagePullSecrets, err := mergeImagePullSecrets(pod.Spec.ImagePullSecrets, podDefaults)
if err != nil {
klog.Error(err)
}
pod.Spec.ImagePullSecrets = imagePullSecrets

var (
defaultAnnotations = make([]*map[string]string, len(podDefaults))
defaultLabels = make([]*map[string]string, len(podDefaults))
Expand Down Expand Up @@ -443,6 +503,27 @@ func applyPodDefaultsOnContainer(ctr *corev1.Container, podDefaults []*settingsa
klog.Error(err)
}
ctr.EnvFrom = envFrom

setCommandAndArgs(ctr, podDefaults)
}

//setCommandAndArgs adds command and args to the provided container. If the container already has a command or arguments set,
// they won't be overwritten by PodDefault.
func setCommandAndArgs(ctr *corev1.Container, podDefaults []*settingsapi.PodDefault) {
// ignore istio sidecar container
if ctr.Name == istioProxyContainerName {
return
}
for _, pd := range podDefaults {
if ctr.Command == nil && pd.Spec.Command != nil {
klog.Info(fmt.Sprintf("Updating container: %v, poddefault: %v, setting command: %v", ctr.Name, pd.GetName(), pd.Spec.Command))
ctr.Command = pd.Spec.Command
}
if ctr.Args == nil && pd.Spec.Args != nil {
klog.Info(fmt.Sprintf("Updating container: %v, poddefault: %v, setting args %v", ctr.Name, pd.GetName(), pd.Spec.Args))
ctr.Args = pd.Spec.Args
}
}
}

func mutatePods(ar v1.AdmissionReview) *v1.AdmissionResponse {
Expand All @@ -463,7 +544,7 @@ func mutatePods(ar v1.AdmissionReview) *v1.AdmissionResponse {
reviewResponse := v1.AdmissionResponse{}
reviewResponse.Allowed = true
if pod.Namespace == "" {
klog.Infof("Namespace was not set explicitly in Pod manifest, falling back to the namespace-'%s' coming from AdmissionReview request", ar.Request.Namespace)
klog.Infof("Namespace was not set explicitly in Pod manifest, falling back to the namespace-'%s' coming from AdmissionReview request", ar.Request.Namespace)
pod.Namespace = ar.Request.Namespace
}

Expand Down Expand Up @@ -519,6 +600,7 @@ func mutatePods(ar v1.AdmissionReview) *v1.AdmissionResponse {
// detect merge conflict
err = safeToApplyPodDefaultsOnPod(&pod, matchingPDs)
if err != nil {
// This code doesn't ignore the error but rejects the Pod.
// conflict, ignore the error, but raise an event
msg := fmt.Errorf("conflict occurred while applying poddefaults: %s on pod: %v err: %v",
strings.Join(defaultNames, ","), pod.GetName(), err)
Expand Down
78 changes: 75 additions & 3 deletions components/admission-webhook/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ func TestApplyPodDefaultsOnPod(t *testing.T) {
[]*settingsapi.PodDefault{
{
Spec: settingsapi.PodDefaultSpec{
Annotations: map[string]string{"baz": "bux"},
ServiceAccountName: "some-service-account",
Annotations: map[string]string{"baz": "bux"},
ServiceAccountName: "some-service-account",
AutomountServiceAccountToken: newTrue(),
},
},
Expand All @@ -110,7 +110,7 @@ func TestApplyPodDefaultsOnPod(t *testing.T) {
Labels: map[string]string{},
},
Spec: corev1.PodSpec{
ServiceAccountName: "some-service-account",
ServiceAccountName: "some-service-account",
AutomountServiceAccountToken: newTrue(),
},
},
Expand Down Expand Up @@ -201,3 +201,75 @@ func TestApplyPodDefaultsOnPod(t *testing.T) {
}

}

func TestSetCommandAndArgs(t *testing.T) {
commandOne := []string{
"cmd1",
}
argsOne := []string{
"arg1",
"arg2",
}
commandTwo := []string{
"cmd2",
}
argsTwo := []string{
"arg3",
"arg4",
}
for _, test := range []struct {
name string
in *corev1.Container
podDefaults []*settingsapi.PodDefault
out *corev1.Container
}{
{
name: "Set command and args",
in: &corev1.Container{},
podDefaults: []*settingsapi.PodDefault{
{
ObjectMeta: metav1.ObjectMeta{
Name: "test-pod-default",
},
Spec: settingsapi.PodDefaultSpec{
Command: commandOne,
Args: argsOne,
},
},
},
out: &corev1.Container{
Command: commandOne,
Args: argsOne,
},
},
{
name: "Do not overwrite command and args in case they are already set",
in: &corev1.Container{
Command: commandTwo,
Args: argsTwo,
},
podDefaults: []*settingsapi.PodDefault{
{
ObjectMeta: metav1.ObjectMeta{
Name: "test-pod-default",
},
Spec: settingsapi.PodDefaultSpec{
Command: commandOne,
Args: argsOne,
},
},
},
out: &corev1.Container{
Command: commandTwo,
Args: argsTwo,
},
},
} {
t.Run(test.name, func(t *testing.T) {
setCommandAndArgs(test.in, test.podDefaults)
if !reflect.DeepEqual(test.in, test.out) {
t.Fatalf("%#v\n Not Equals:\n%#v", test.in, test.out)
}
})
}
}
Loading

0 comments on commit bcbae2e

Please sign in to comment.