Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.7 vulnerabilities #141

Merged
merged 10 commits into from
Jun 26, 2023
Merged

Fix 1.7 vulnerabilities #141

merged 10 commits into from
Jun 26, 2023

Conversation

wg102
Copy link

@wg102 wg102 commented Jun 21, 2023

Closes https://github.com/StatCan/aaw-private/issues/97

Still 2 moderate vulnerabilities, discussing at elaboration

@wg102 wg102 requested a review from mathis-marcotte June 21, 2023 19:55
@wg102 wg102 mentioned this pull request Jun 21, 2023
Closed
mathis-marcotte
mathis-marcotte approved these changes Jun 22, 2023
View reviewed changes
Copy link

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Only 2 moderate vulnerabilities left with no fix available. App ran locally. lgtm

@wg102 wg102 merged commit 3546eee into kf1.7-upgrade Jun 26, 2023
@wg102 wg102 deleted the fix-1.7-vulnerabilities branch June 26, 2023 13:48
@wg102
Copy link
Author

wg102 commented Jun 26, 2023

The two left moderate vulnerabilities should not affect our code the way we use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathis-marcotte mathis-marcotte mathis-marcotte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wg102 @mathis-marcotte