Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #157 - webpack error during build #160

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

lrasmus
Copy link
Contributor

@lrasmus lrasmus commented Feb 14, 2024

(Hopefully) addresses the webpack error that happens when yarn install is run

Thanks to @Abhijay007 for an earlier draft fix which pointed me in this direction of investigation.

(Hopefully) addresses the webpack error that happens when `yarn install` is run
@lrasmus
Copy link
Contributor Author

lrasmus commented Feb 14, 2024

@Abhijay007 - any chance you'd be willing to review and see if this works for you?

@Abhijay007
Copy link
Contributor

@Abhijay007 - any chance you'd be willing to review and see if this works for you?

sure, looking into this

Copy link
Contributor

@Abhijay007 Abhijay007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrasmus It LGTM 👍 . I followed all the steps mentioned by you earlier on my machine, and this approach worked.

@lrasmus
Copy link
Contributor Author

lrasmus commented Feb 14, 2024

Thanks so much for the collaboration in getting this fixed @Abhijay007!

@lrasmus lrasmus merged commit 0564b55 into master Feb 14, 2024
@lrasmus lrasmus deleted the yarn_install_error branch February 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants