Treat response.text() as a promise in error handling.

We [recently added some better exception handling](#9) but unfortunately printing the response body didn't work because [`response.text()` is a Promise](https://github.github.io/fetch/#response-body). The message looks like this: `ThriftRequestError: Thrift request failed: HTTP 503 Service Unavailable: [object Promise]` The fix is to use `.then()` to get the body.
StatesTitle · Jul 5, 2022 · 01802d2 · 01802d2
1 parent 9c02a7d
commit 01802d2
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/packages/thrift-client/src/main/connections/HttpConnection.ts b/packages/thrift-client/src/main/connections/HttpConnection.ts
@@ -207,14 +207,20 @@ export class HttpConnection extends ThriftConnection<RequestOptions> {
           if (shouldRetry(response, retry, this.withEndpointPerMethod)) {
             resolve(this.write(dataToWrite, methodName, options, true))
           } else if (isErrorResponse(response)) {
-            reject(
-              new ThriftRequestError(
-                `Thrift request failed: HTTP ${response.status} ${
-                  response.statusText
-                }: ${response.text()}`,
-                response
+            const baseMessage = `Thrift request failed: HTTP ${response.status} ${response.statusText}`
+            response
+              .text()
+              .then(responseText =>
+                reject(new ThriftRequestError(`${baseMessage}: ${responseText}`, response))
               )
-            )
+              .catch(reason => {
+                reject(
+                  new ThriftRequestError(
+                    `${baseMessage} and the response body could not be read: ${reason}`,
+                    response
+                  )
+                )
+              })
           } else {
             response.arrayBuffer().then(arrayBuffer =>
               resolve({