Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

fix: properly handle default group and filter #1083

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

KaneFreeman
Copy link
Collaborator

Fixes #1082

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for demo-staticjscms ready!

Name Link
🔨 Latest commit eecc4da
🔍 Latest deploy log https://app.netlify.com/sites/demo-staticjscms/deploys/65c4f49cc0e20d00099e1b60
😎 Deploy Preview https://deploy-preview-1083.demo.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for staticjscms ready!

Name Link
🔨 Latest commit eecc4da
🔍 Latest deploy log https://app.netlify.com/sites/staticjscms/deploys/65c4f49cb633ce0008fe4223
😎 Deploy Preview https://deploy-preview-1083.staticcms.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ccd242c) 55.87% compared to head (9fca472) 55.87%.

❗ Current head 9fca472 differs from pull request most recent head eecc4da. Consider uploading reports for the commit eecc4da to get more accurate results

Files Patch % Lines
packages/core/src/actions/entries.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   55.87%   55.87%           
=======================================
  Files         259      259           
  Lines       12318    12318           
  Branches     3090     3090           
=======================================
  Hits         6883     6883           
  Misses       5028     5028           
  Partials      407      407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaneFreeman KaneFreeman force-pushed the fix/properly-handle-default-group-and-filter branch from 4357297 to 9fca472 Compare February 8, 2024 14:07
@oliverpool
Copy link
Contributor

I can confirm that the glitch seems to be gone, thank you!

@KaneFreeman KaneFreeman force-pushed the fix/properly-handle-default-group-and-filter branch from 9fca472 to f60c496 Compare February 8, 2024 15:31
@KaneFreeman KaneFreeman force-pushed the fix/properly-handle-default-group-and-filter branch from f60c496 to eecc4da Compare February 8, 2024 15:34
@KaneFreeman KaneFreeman merged commit 2c72215 into main Feb 8, 2024
17 checks passed
@KaneFreeman KaneFreeman deleted the fix/properly-handle-default-group-and-filter branch February 8, 2024 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants