Uninstall script addition #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First pass for a version that looks similar to the install scripts
Add uninstall script info to readme
Closed
TrainDoctor
requested changes
Apr 28, 2022
Only remove services for now Co-authored-by: TrainDoctor <11465594+TrainDoctor@users.noreply.github.com>
|
Changes committed, although a full uninstall option would be helpful to consider at some point. |
No longer deletes installed plugins, adjusted echo to match actions.
While I agree, I think at this early in development making sure re-installs will work with no questions asked is a higher priority for the time being. And if users don't like the folder sticking around then they can delete them in desktop mode as needed. Your point is very much taken and a goal should be set to have a full clear script either as an interactive option or just an alternative script. Thanks for your contribution! @WerWolv and @marios8543 this looks good to merge. |
KP2048
pushed a commit
to EmuDeck/decky-loader
that referenced
this pull request
May 4, 2023
* Create uninstall.sh * Update uninstall.sh First pass for a version that looks similar to the install scripts * Update readme with uninstall info Add uninstall script info to readme * Update dist/uninstall.sh Only remove services for now Co-authored-by: TrainDoctor <11465594+TrainDoctor@users.noreply.github.com> * Adjust echo to accurately reflect script actions No longer deletes installed plugins, adjusted echo to match actions. Co-authored-by: TrainDoctor <11465594+TrainDoctor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added uninstall script based on the answer provided to #46.