Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom TitleView #512

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Add Custom TitleView #512

merged 3 commits into from
Jul 27, 2023

Conversation

beebls
Copy link
Contributor

@beebls beebls commented Jul 23, 2023

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

Description

This is an addition that allows plugin developers to change the titleView of their plugin. Currently, it is just a <div style={{ flex: 0.9 }}>{activePlugin.name}</div>. If a plugin has the titleView prop in their definePlugin return value, it will now display that instead of the boilerplate name.

This does not allow for removal of the back button, as that is crucial to ensuring people can exit out of plugins, the custom titleView slots in to the right of the back button.

Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but should probably be tested by someone before being merged

@PartyWumpus
Copy link
Member

image
Tested and it works fully.

@PartyWumpus PartyWumpus merged commit c7e4eb1 into main Jul 27, 2023
4 checks passed
@beebls beebls deleted the beebls/custom-titleview branch September 14, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants