Add static typing to Python & add type checking CI #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WerWolv
force-pushed
the
aa/type-cleanup-py
branch
from
3c21128
to
3960d28
Compare
WerWolv
force-pushed
the
aa/type-cleanup-py
branch
from
0ccb120
to
a0d50ba
Compare
|
merged manually in a766979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
This adds static types to all of the backend Python code, along with CI to verify that no new type errors are created in commits and PRs.
The CI also checks TypeScript types, so some of the frontend code was edited to make strict type checking work correctly.
Additionally, the Python backend was modified to use module imports instead of name imports, to prevent module collisions. Because of this, we now need a
main.pyin the repo root to serve as the non-module pyinstaller entrypoint.Due to the scope of this PR, I'd like to make sure everything is tested and working before it's merged. In the future, this should make loader PR review much easier.