Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix id keyerror on plugin uninstall #725

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Conversation

suchmememanyskill
Copy link
Contributor

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
    • Completely untested
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: An issue has been reported in the steam deck homebrew discord that uninstalling plugins give a keyerror on uninstall. This fixes that

@eXhumer
Copy link
Contributor

eXhumer commented Dec 12, 2024

semi-colon

@suchmememanyskill
Copy link
Contributor Author

Nice catch, wouldn't have done much but still.

Can you tell i primarly code c# professionally? 😄

@eXhumer
Copy link
Contributor

eXhumer commented Dec 13, 2024

Looks good. I'll test this later today and report back the results.

Copy link
Contributor

@eXhumer eXhumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No more KeyError: id while trying to uninstall/re-install already installed plugins.

@AAGaming00 AAGaming00 merged commit 83f2c94 into main Dec 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants