-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NonSteamLaunchers as a submodule #469
Conversation
@TrainDoctor @AAGaming00 i re-did the Pull Request again because my repo got all messed up. Sorry about that. Ive made the changes that you requested, added the template license, fixed the global styles, got rid of any extra buttons. I also kept some of the code in the .tsx file so that way i can work on it later, its been "commented" out so i can work on it later. none of that code will be executed. Ive tested this on Stable and it install the launchers fine. |
Wow, and I thought I wrote long shell scripts. Good to go to testing. |
@TrainDoctor what do I need to do from here any other things? |
@moraroy it's up to the @SteamDeckHomebrew/decky-testers to test the plugins do it can go onto the production store. |
@TrainDoctor gotcha ok thank you, if I were to update my plug-in, I would update it with all the new changes. And then update "just the submodule" on the forked database to update it right? |
Yup! |
@TrainDoctor hey train, i attempted a small update/fix to the plugin and then attempted to update the "submodule" im not sure if i did it correctly haha |
@SteamDeckHomebrew/decky-testers please give this a whirl. |
@TrainDoctor hey train, I'm not sure if the one in the testing store is the correct one, it's version 0.1, that one is broken and I think it's from the old pull request, I have been trying to bump up the pull request to 0.3 which is the fixed one and works properly just not sure if I've done that correctly here on github already. |
It appears you have been syncing to the latest versions of the repo but you have not been updating your submodule. Doing so should update the version of the plugin on the testing store after it's build is approved and you should be back in business. |
@TrainDoctor are these the right commands...from the discord. When adding a new plugin, run the following:
and for plugin updates, run: ```
|
Yes, I've had to use submodules a few times in my own repos and these should do the trick. |
@TrainDoctor hey brother not sure why this closed the pull request... it asked me on github to resolve the conflicts so i did, but i didnt know it was going to close the pull request.. So i went to my local copy of the database and ran this git submodule update --init "plugins/NonSteamLaunchersDecky" but it doesnt do anything. |
I cannot re-open the PR myself as it's not my or my orgs PR. I'm not sure what's going on with your submodules. I don't have time to debug the issue myself but I would look into git submodule syntax in their documentation and on stackoverflow etc. |
NonSteamLaunchers
Installs the latest GE-Proton and Installs Non Steam Launchers under 1 Proton prefix folder (or Separate) and adds them to your steam library. Installs... Battle.net, Epic Games, Ubisoft, GOG, Origin, The EA App, Amazon Games, itch.io , Legacy Games, The Humble Games Collection, IndieGala, Rockstar Games Launcher, Glyph and Minecraft. Now with SD Card Support .
Re-adding due to corrupted repo
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing