-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDH-PauseGames to v1.0.0 #716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for testing after code review.
Very to happy see the continue on. I remember when @popsUlfr first got involved and put together various interesting plugins and I'm glad we get too see that handed off to new talent.
I've tested it to be working well if it counts 😃 |
Hmm... I just realized that the store's screenshot hasn’t been updated to reflect our v1.0.0 version, updating now. |
Done! the store's screenshot for SDH-PauseGames has been updated to reflect our v1.0.0 version, please have a look, thanks you! |
Wish I could. We require a tester who isn't credited with the development of the plugin actively i.e. maintainers or large contributors. |
@wynn1212, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines. |
@wynn1212 tested latest version you have here, I like it a lot, but ui is a tad confusing, if I have the game unchecked to the right hand toggle, does that just mean it doesnt apply to the pause on sleep or focus loss criteria? I was still able to pause it by clicking on the game logo (which is a nice touch btw). I just found the UI a bit confusing, my expectation was if I unchecked the game then its disqualified from any pausing, if checked then I could manually pause and/or have it apply to the conditionals at the top. Please let me know if I am looking at it wrong though! |
@xXJSONDeruloXx it will only affect automatically pausing since manual pausing is your choice to be made, so I see no reason that this toggle should include that. There will be an update that hides this toggle if automatic pausing is disabled (together with other changes I'm trying to figure out). |
sounds good, and that all makes sense. also tested the force kill while app is paused by the plugin, I am now seeing in all trials so far it does exit cleanly, no more black screen with a remaining process requiring a restart of steam. Great plugin, one of my favorites of all time! |
@TrainDoctor Sure thing, I'll help to test other plugin later on. As I'm always stay on testing channel. |
Please make sure to include this format in plugin testing reports you do: Decky version(s), SteamOS version(s) |
Testing reportDecky Version: 3.1.2-pre1 A) Major IssuesNone found B) Minor IssuesNone found C) Installed Plugins
D) Production Store RecommendationYay Additional NotesGames pause and resume as expected when suspending and manually pausing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testers approve, off to production.
Pause Games
Update SDH-PauseGames to v1.0.0 with the following fixes and new features:
stickyPause
state on manual resume.noAutoPauseSet
to select which game shouldn't be paused when on focus loss; this can be toggled on the right side of the Pause Games list.SteamClient.Apps.TerminateApp()
to un-pause games on exit.Special thanks to @AkazaRenn for contributing new features and fixes.
This fork has been approved by the original author, @popsUlfr, allowing me and @AkazaRenn to take over the project to continue supporting and expanding the plugin.
Since @popsUlfr is currently stepping away from Decky and plugin development, @popsUlfr has granted me and @AkazaRenn permission to maintain this project going forward.
Source for approval:
Once again, a big thanks to the original author, @popsUlfr, for creating this amazing plugin in the first place and supporting us in taking on this project.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing