Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDH-PauseGames to v1.0.0 #716

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

wynn1212
Copy link
Contributor

@wynn1212 wynn1212 commented Oct 29, 2024

Pause Games

Update SDH-PauseGames to v1.0.0 with the following fixes and new features:

Special thanks to @AkazaRenn for contributing new features and fixes.

This fork has been approved by the original author, @popsUlfr, allowing me and @AkazaRenn to take over the project to continue supporting and expanding the plugin.
Since @popsUlfr is currently stepping away from Decky and plugin development, @popsUlfr has granted me and @AkazaRenn permission to maintain this project going forward.

Source for approval:

Once again, a big thanks to the original author, @popsUlfr, for creating this amazing plugin in the first place and supporting us in taking on this project.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for testing after code review.
Very to happy see the continue on. I remember when @popsUlfr first got involved and put together various interesting plugins and I'm glad we get too see that handed off to new talent.

@TrainDoctor TrainDoctor requested review from a team October 29, 2024 23:12
@AkazaRenn
Copy link

I've tested it to be working well if it counts 😃

@wynn1212
Copy link
Contributor Author

Hmm... I just realized that the store's screenshot hasn’t been updated to reflect our v1.0.0 version, updating now.

@wynn1212
Copy link
Contributor Author

Done! the store's screenshot for SDH-PauseGames has been updated to reflect our v1.0.0 version, please have a look, thanks you!

@TrainDoctor
Copy link
Member

I've tested it to be working well if it counts 😃

Wish I could. We require a tester who isn't credited with the development of the plugin actively i.e. maintainers or large contributors.

@TrainDoctor
Copy link
Member

@wynn1212, I am currently experimenting with a concept for testing plugin submissions and plugin updates. I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

@xXJSONDeruloXx
Copy link
Contributor

@wynn1212 tested latest version you have here, I like it a lot, but ui is a tad confusing, if I have the game unchecked to the right hand toggle, does that just mean it doesnt apply to the pause on sleep or focus loss criteria? I was still able to pause it by clicking on the game logo (which is a nice touch btw). I just found the UI a bit confusing, my expectation was if I unchecked the game then its disqualified from any pausing, if checked then I could manually pause and/or have it apply to the conditionals at the top. Please let me know if I am looking at it wrong though!

image

@AkazaRenn
Copy link

AkazaRenn commented Jan 13, 2025

@xXJSONDeruloXx it will only affect automatically pausing since manual pausing is your choice to be made, so I see no reason that this toggle should include that. There will be an update that hides this toggle if automatic pausing is disabled (together with other changes I'm trying to figure out).

@xXJSONDeruloXx
Copy link
Contributor

sounds good, and that all makes sense. also tested the force kill while app is paused by the plugin, I am now seeing in all trials so far it does exit cleanly, no more black screen with a remaining process requiring a restart of steam. Great plugin, one of my favorites of all time!

@wynn1212
Copy link
Contributor Author

@TrainDoctor Sure thing, I'll help to test other plugin later on. As I'm always stay on testing channel.

@TrainDoctor
Copy link
Member

@xXJSONDeruloXx

Please make sure to include this format in plugin testing reports you do:

Decky version(s), SteamOS version(s)
A) Any major blocking issues that you encountered, if any.
B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
C) A list of currently installed plugins (Name and version preferred)
(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.

@OMGDuke
Copy link
Contributor

OMGDuke commented Jan 13, 2025

Testing report

Decky Version: 3.1.2-pre1
SteamOS Version: 3.6.20

A) Major Issues

None found

B) Minor Issues

None found

C) Installed Plugins

  • ProtonDB Badges v1.1.0
  • Game Theme Music v1.7.0
  • SteamGridDB v1.5.1
  • Pause Games v1.0.0-b2be59f
  • CSS Loader v2.1.2

D) Production Store Recommendation

Yay

Additional Notes

Games pause and resume as expected when suspending and manually pausing.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers approve, off to production.

@TrainDoctor TrainDoctor merged commit 92e20dd into SteamDeckHomebrew:main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants