-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new Steam authentication #401
Conversation
Can probably drop SentryFileHash/accepting machine auth with this. |
I haven't had a chance to go over it with a fine-toothed comb but this seems to be working well enough, if it breaks then I'm happy to take bug reports as they come in. |
@@ -553,14 +639,14 @@ private void LogOnCallback(SteamUser.LoggedOnCallback loggedOn) | |||
{ | |||
var isSteamGuard = loggedOn.Result == EResult.AccountLogonDenied; | |||
var is2FA = loggedOn.Result == EResult.AccountLoginDeniedNeedTwoFactor; | |||
var isLoginKey = ContentDownloader.Config.RememberPassword && logonDetails.LoginKey != null && loggedOn.Result == EResult.InvalidPassword; | |||
var isAccessToken = ContentDownloader.Config.RememberPassword && logonDetails.AccessToken != null && loggedOn.Result == EResult.InvalidPassword; // TODO: Get EResult for bad access token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codes I've seen are InvalidSignature and AccessDenied.
InvalidPassword probably happens when sending password in logon.
I probably don't belong here, but while i was testing your code, i noticed a minor error at
You provide 5 arguments to string.format via Console.WriteLine, the formatted string only has 4. Can be fixed by adding {4} .Console.WriteLine("Got Machine Auth: {0} {1} {2} {3} {4}", machineAuth.FileName, machineAuth.Offset, machineAuth.BytesToWrite, machineAuth.Data.Length, hash);
Edit: clarified ConsoleWriteline, not string.format |
Just to clarify, does this allow the use of -remember-password (referenced by #397)? Trying out v2.5.0 tonight and I seem to be getting multiple Steam Guard verification code requests. Example:
leads to multiple requests for the account password, then a subsequent Steam Guard code via email. |
No description provided.