Dispose objects where possible #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychonic
approved these changes
Oct 18, 2023
yaakov-h
reviewed
Oct 19, 2023
| @@ -112,7 +111,9 @@ public IDisposable Subscribe<TCallback>( JobID jobID, Action<TCallback> callback | |||
| throw new ArgumentNullException( nameof(callbackFunc) ); | |||
| } | |||
|
|
|||
| #pragma warning disable CA2000 // Not implicitly disposed | |||
There was a problem hiding this comment.
I suspect this is warning because the Subscription constructor could throw, and this remains undisposed.
yaakov-h
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One big object is
MsgBasewhich holds a memory stream and binary readers, but making that disposable requires a bit of a refactor.