Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaderboards #153

Merged
merged 5 commits into from
Aug 31, 2015
Merged

Leaderboards #153

merged 5 commits into from
Aug 31, 2015

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Aug 26, 2015

  • Adds ELeaderboardDisplayType enum
  • 2 new callbacks: FindOrCreateLeaderboardCallback and LeaderboardEntriesCallback
  • 3 new methods: FindLeaderboard, CreateLeaderboard and GetLeaderboardEntries

voided
voided reviewed Aug 27, 2015
View reviewed changes
SteamKit2/SteamKit2/Steam/Handlers/SteamUserStats/Callbacks.cs
SteamID = new SteamID( entry.steam_id_user );
UGCId = new UGCHandle( entry.ugc_id );

// entry.details // TODO: ???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd probably want to expose this the same way Steam does, as an array of 32 bit ints, but I imagine it's not that pressing.

@voided
Copy link
Member

voided commented Aug 27, 2015

LGTM, as-is.

@Netshroud
Copy link

LGTM 👍

voided added a commit that referenced this pull request Aug 31, 2015
@voided
Merge pull request #153 from xPaw/leaderboards
12b9394 
Expose leaderboards
@voided voided merged commit 12b9394 into SteamRE:master Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @voided @Netshroud