Provide functions/callbacks for offline/historical friend message requests #193
Conversation
| /// Offline messages are marked by having set | ||
| /// <see cref="CMsgClientFSGetFriendMessageHistoryResponse.FriendMessage.unread"/> to true | ||
| /// </summary> | ||
| public List<CMsgClientFSGetFriendMessageHistoryResponse.FriendMessage> Messages { get; private set; } |
There was a problem hiding this comment.
We'd want to wrap this into an inner class, check out how the SteamApps callbacks do this.
|
Do you know offhand if these messages support JobIDs? If so, we'd want to expose that. |
|
I tried (in the same way ignoreFriend does it), but the returned JobIDs in the response always were different. Might just be my inexperience with the system though |
|
@CruelCow any plans to finish up this PR with my comment regarding wrapping |
|
@voided Yeah, I have just been busy. Should be ready by tomorrow |
Current coverage is
|
| public bool Unread { get; private set; } | ||
|
|
||
| /// <summary> | ||
| /// The actualy message |
|
Looks good other than a few nits. |
|
|
||
| internal FriendMessage( CMsgClientFSGetFriendMessageHistoryResponse.FriendMessage msg ) | ||
| { | ||
| SteamID = new SteamID(msg.accountid); |
There was a problem hiding this comment.
If this is accountid, shouldn't it be constructed with universe and other bits of information?
There was a problem hiding this comment.
Good catch. I think this also won't construct correctly (it will call the ulong constructor). Valve's code has a similar problem, but they've got a private uint constructor to prevent calling the ulong one accidentally.
Provide functions/callbacks for offline/historical friend message requests
|
Thanks! |
No description provided.