Mark LogOff-triggered disconnections as user-initiated #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
Netshroud
force-pushed
the
logoff-handling
branch
from
1f740e3 to
348600c
Compare
Netshroud
changed the title
|
Re-did this a lot simpler to resolve #181. |
| /// If this is true when the connection is closed, the <see cref="SteamClient.DisconnectedCallback"/>'s <see cref="SteamClient.DisconnectedCallback.UserInitiated"/> property | ||
| /// will be set to <c>true</c>. | ||
| /// </summary> | ||
| public bool ExpectDisconnection { get; set; } |
There was a problem hiding this comment.
Don't think this needs to be entirely public, consumers might be able to misuse it.
There was a problem hiding this comment.
I was thinking that, but I don't want our own ClientMsgHandlers to be able to do things that consumer-built ones cannot.
There was a problem hiding this comment.
CMClient could likely handle that logic based on the emsg being passed to Send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to do a few hacky things I don't particularly like. Any suggestions to improve this?
Ideally, this probably needs a full-blown state machine.