Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain Server List Ordering #218

Merged
merged 6 commits into from
Dec 20, 2015
Merged

Maintain Server List Ordering #218

merged 6 commits into from
Dec 20, 2015

Conversation

Netshroud
Copy link

Resolves #178.

@Netshroud Netshroud added this to the 1.7.0 milestone Dec 13, 2015
@codecov-io
Copy link

Current coverage is 17.63%

Merging #218 into master will increase coverage by +0.05% as of 5bdd087

@@            master    #218   diff @@
======================================
  Files           67      67       
  Stmts         7292    7287     -5
  Branches       520     519     -1
  Methods          0       0       
======================================
+ Hit           1282    1285     +3
+ Partial         73      71     -2
+ Missed        5937    5931     -6

Review entire Coverage Diff as of 5bdd087

Powered by Codecov. Updated on successful CI builds.

xPaw
xPaw reviewed Dec 15, 2015
View reviewed changes
SteamKit2/SteamKit2/Networking/Steam3/CMServerList.cs
}
}
}

void Add( IPEndPoint endPoint )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing besides UseInbuiltList calls this method, I'd say just remove it.

@Netshroud Netshroud merged commit 2e9c836 into master Dec 20, 2015
@Netshroud Netshroud deleted the smart-server-list-2 branch March 28, 2017 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Netshroud @codecov-io @xPaw @yaakov-h