Invoke AsyncJob continuations asynchronously #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voided
approved these changes
Oct 25, 2017
There was a problem hiding this comment.
Good catch, my 7am brain didn't initially understand what it was looking at in the stack trace in #480.
I think it's unsafe to run continuations on the network thread, especially since consumer code might block on other operations (or deadlock like we see in #480). Must have been an oversight on my part from the original implementation of AsyncJobs.
leonard-thieu
added a commit
to leonard-thieu/SteamKit
that referenced
this pull request
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480.