Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundwork for new friends/chat system #565

Merged
merged 8 commits into from
Jun 13, 2018

Conversation

yaakov-h
Copy link
Member

@yaakov-h yaakov-h commented Jun 13, 2018

  • New EMsg, ServiceMethodCallFromClient = 151. Message body is the unified messages protobuf.
  • Newly used EMsg, ServiceMethodResponse, which is a response to a ServiceMethodCallFromClient. Message body is the unified messages protobuf.
  • New chat system uses new protobufs that are not defined in steamclient.dll/.dylib/.so. The only version available currently is in Javascript, in friends.js. Check out deserializeBinaryFromReader. We may need a new version of ProtobufDumper that transforms the JS into .proto files.

@codecov-io
Copy link

codecov-io commented Jun 13, 2018

Codecov Report

Merging #565 into steamclient-beta will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           steamclient-beta     #565   +/-   ##
=================================================
  Coverage             22.09%   22.09%           
=================================================
  Files                    86       86           
  Lines                  8666     8666           
  Branches                714      714           
=================================================
  Hits                   1915     1915           
  Misses                 6624     6624           
  Partials                127      127
Impacted Files Coverage Δ
...SteamKit2/Steam/Handlers/SteamFriends/Callbacks.cs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed700b1...9343017. Read the comment docs.

@yaakov-h yaakov-h changed the title [WIP] New friends/chat system Groundwork for new friends/chat system Jun 13, 2018
@yaakov-h yaakov-h mentioned this pull request Jun 13, 2018
@yaakov-h yaakov-h merged commit 61a93cf into steamclient-beta Jun 13, 2018
@yaakov-h yaakov-h deleted the wip/new-chat-system branch June 13, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants