CurrentProtocol bump #568
Merged
CurrentProtocol bump #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 22.09% 22.12% +0.02%
==========================================
Files 86 86
Lines 8666 8666
Branches 714 714
==========================================
+ Hits 1915 1917 +2
Misses 6624 6624
+ Partials 127 125 -2
Continue to review full report at Codecov.
|
|
I'd be happy to discuss why on IRC if you're interested. |
This was referenced Aug 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#567 retargetted against master branch with recommended fixes.
@voided @yaakov-h Any particular reason what issues package version bump can bring and why we should stick to that initial version?