Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sent/recv debug messages #774

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Remove sent/recv debug messages #774

merged 2 commits into from
Nov 2, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 2, 2019

DebugNetworkListener can be used for this purpose.

This will actually make DebugLog easier to enable without having to worry about the packet spam.

DebugNetworkListener can be used for this purpose.
@codecov
Copy link

codecov bot commented Nov 2, 2019

Codecov Report

Merging #774 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   22.76%   22.74%   -0.02%     
==========================================
  Files          94       94              
  Lines        9304     9306       +2     
  Branches      770      770              
==========================================
- Hits         2118     2117       -1     
- Misses       7052     7055       +3     
  Partials      134      134
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Util/DebugNetworkListener.cs 0% <0%> (ø) ⬆️
SteamKit2/SteamKit2/Base/ClientMsg.cs 22.98% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611c1dd...6ca7648. Read the comment docs.

@yaakov-h
Copy link
Member

yaakov-h commented Nov 2, 2019

I find these useful. 😢

Can we move it to DebugNetworkListener?

@xPaw
Copy link
Member Author

xPaw commented Nov 2, 2019

I added them to NetHookNetworkListener, is that good enough?

@yaakov-h
Copy link
Member

yaakov-h commented Nov 2, 2019

I think so. That should be the EMsg without the high-bit for proto.

@xPaw
Copy link
Member Author

xPaw commented Nov 2, 2019

It practically logs in the same place as the logs i removed (except for the fact that multis will be split).

@yaakov-h yaakov-h merged commit c256b70 into SteamRE:master Nov 2, 2019
@xPaw xPaw mentioned this pull request Mar 12, 2020
@xPaw xPaw deleted the patch-7 branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants