Added a function wrapper to set_sprites to allow Jokers to have custom atlases without jank #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m atlases without jank
…through the logic again
|
Hello, thanks for the PR I will test it. If it works correctly, it will appear in the JokerAPI release. |
|
The Joker API entered PRE Release phase, I will merge this after I'm sure everything is good on the JAPI part. |
|
I will also edit the Sprite object to better understand custom sprite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the "atlas" variable only does something the SECOND time set_sprites is called, and this code is only needed to exist once generically alongside being generic itself so there is no real reason not to have it within steamodded itself