use rand's SmallRng for random number generation #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Mar 25, 2021
src/util.rs
Outdated
| use std::{io, str}; | ||
|
|
||
| use crate::error::IoResultExt; | ||
|
|
||
| thread_local! { | ||
| static THREAD_RNG_KEY: Rc<UnsafeCell<SmallRng>> = Rc::new(UnsafeCell::new(SmallRng::from_entropy())); |
There was a problem hiding this comment.
We can drop the Rc, right? Just use THREAD_RNG_KEY.with(|rng| use rng...).
Stebalien
approved these changes
Apr 9, 2021
Closed
|
@Stebalien sorry I totally spaced on getting those changes in, thanks so much for merging! |
ironhaven
added a commit
to ironhaven/tempfile
that referenced
this pull request
Nov 20, 2021
This patch does two things 1. Reverts Stebalien#141 by removing handspun SmallRng thread_rng that used unsafe *note Was it a security vulnerability to use a non CSPRNG for tempfiles? 2. Replace use of str::from_utf8_unchecked with char::encode_utf8 Examining the assembly shows no panics generated from encode_utf8 The only functional differences of this patch is replacing SmallRng with a slightly slower RNG and purging unsafe code from a module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119 seems to have not been updated, so here's another take at it, trying to keep the diff as small as possible.
This approach stores a
SmallRngas a thread-local variable, basically directly copying the wayranddoes its ownthread_rng()so as to avoid any issues or incompatibilities.I opted not to further change the way that the
OsStringis built since that feels like it may be better in another PR.