Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only depend on kernel32 and winapi on Windows #37

Conversation

chris-morgan
Copy link

kernel32 and winapi are completely pointless for non-Windows builds. (They’re empty crates on non-Windows owing to a #![cfg(windows)] crate attribute so that they build.) They shouldn’t even be depended on for non-Windows builds.

The duplication is ugly, but necessary for now; see also rust-lang/cargo#1007

`kernel32` and `winapi` are completely pointless for non-Windows builds.
(They’re empty crates on non-Windows owing to a `#![cfg(windows)]` crate
attribute so that they build.)
They shouldn’t even be depended on for non-Windows builds.

The duplication is ugly, but necessary for now; see also
rust-lang/cargo#1007
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Collaborator

For now we're idiomatically just adding these dependencies to avoid the duplication across all our crates. For example the rand crate also depends on these two crates. Build times shouldn't be affected by this very much at all and in general it seems like there aren't enough cons to warrant this for now. We can certainly do so once the associated Cargo issue is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants