add stub implementation of extract_noattr for other platforms #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows xattr to at least compile on platforms like illumos, even though it isn't really supported there.
sunshowers
added a commit
to nextest-rs/nextest
that referenced
this pull request
Dec 10, 2023
tar 0.4.40 doesn't compile on illumos, due to Stebalien/xattr#48. Downgrade tar to 0.4.39, which downgrades xattr to version 0.2.
1 task
|
Does enabling the "unsupported" feature not work for you? |
|
Hmm, I'm using xattr as a transitive dependency of the tar package. It's possible that could work (I haven't tried) but I think it doesn't feel right to depend on that? |
|
Looks like the unsupported feature is enabled by default, yet |
|
Thank you sunshowers, this is great. It works on OmniOS. |
|
Ah... I see. |
|
This should now be fixed on the latest release. |
|
Thanks! Your solution (2352bdc) looks great. |
sunshowers
added a commit
to sunshowers/tar-rs
that referenced
this pull request
Dec 12, 2023
xattr 1.0.0 through 1.1.2 have a bug (Stebalien/xattr#48). Bump the requirement so that downstream dependents get the latest version.
alexcrichton
pushed a commit
to alexcrichton/tar-rs
that referenced
this pull request
Jun 4, 2024
xattr 1.0.0 through 1.1.2 have a bug (Stebalien/xattr#48). Bump the requirement so that downstream dependents get the latest version.
ararslan
pushed a commit
to ararslan/binstall-tar
that referenced
this pull request
Jun 6, 2024
xattr 1.0.0 through 1.1.2 have a bug (Stebalien/xattr#48). Bump the requirement so that downstream dependents get the latest version. (cherry picked from commit c74d62a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows xattr to at least compile on platforms like illumos, even though it isn't currently supported there.