Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing regex literals #111

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat: support parsing regex literals #111

merged 4 commits into from
Oct 31, 2024

Conversation

tommy
Copy link
Contributor

@tommy tommy commented Oct 31, 2024

This doesn't yet add support for doing anything wiht them – the evaluator still panics when it reaches one.

thread 'main' panicked at src/evaluator.rs:135:18:
not implemented: TODO: node kind not yet supported: Regex(
    RegexLiteral(
        Regex(
            "[0-9]",
        ),
    ),
)

Note: we should probably switch from regex to https://docs.rs/regress/latest/regress/ , which targets the javascript regex syntax, which I assume JSONata uses (or at least is closer to).

@tommy tommy marked this pull request as draft October 31, 2024 20:05
@tommy tommy marked this pull request as ready for review October 31, 2024 20:12
Copy link
Member

@aesterline aesterline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@tommy tommy enabled auto-merge (squash) October 31, 2024 20:30
@tommy tommy merged commit 720e781 into main Oct 31, 2024
8 checks passed
@tommy tommy deleted the t/regex-literal branch October 31, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants