feat: Add support for regex expressions #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakraog
changed the title
deepakraog
changed the title
tommy
reviewed
Nov 15, 2024
There was a problem hiding this comment.
I replaced the replacement string handling for $replace with a new parser for the match groups. I think there are too many sledge cases to do it reliably with splitting/etc. those tests pass now, haven't gotten to the failing tests using replacement functions.
tommy
changed the title
|
Remaining test cases are passing. Evaluating the Value::Lambda (for the "replace with function call" syntax) apparently returns another Value::Lambda. So, I reused the trampoline loop from a different part of the evaluator to repeatedly evaluate until reaching a final result. |
aesterline
approved these changes
Nov 17, 2024
tommy
approved these changes
Nov 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for regex expressions #96