Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left-overs from assembly signing #1009

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented Sep 5, 2022

Description

This PR removes non-working left-overs from the codebase, related to assembly signing (which is not to be confused with NuGet package signing). As explained at #18 (comment), there's no benefit it trying to pursue this on .NET Core and later versions.

Fixes #18.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware
Copy link
Member Author

/azp run Steeltoe.All

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bart-vmware bart-vmware marked this pull request as ready for review September 5, 2022 16:45
@bart-vmware bart-vmware requested a review from TimHess September 5, 2022 16:45
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bart-vmware bart-vmware merged commit 095967c into main Sep 7, 2022
@bart-vmware bart-vmware deleted the remove-asembly-signing branch September 7, 2022 11:46
@TimHess TimHess added this to the 4.0.0-alpha milestone Dec 5, 2022
@bart-vmware bart-vmware added the ReleaseLine/4.x Identified as a feature/fix for the 4.x release line label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseLine/4.x Identified as a feature/fix for the 4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Steeltoe assemblies do not have strong name information
2 participants