Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a new feature #2

Open
sys1874 opened this issue Apr 3, 2018 · 3 comments
Open

a new feature #2

sys1874 opened this issue Apr 3, 2018 · 3 comments

Comments

@sys1874
Copy link

sys1874 commented Apr 3, 2018

@StefOe hello StefOe, i just wonder if it is possible to add a new feature :bidirectional

@sbrugman
Copy link

I would also find that useful. The LSTM implementation in PyTorch could be a helpful reference point:
https://pytorch.org/docs/master/_modules/torch/nn/modules/rnn.html#LSTM

StefOe pushed a commit that referenced this issue Jun 1, 2018
@StefOe
Copy link
Owner

StefOe commented Jun 1, 2018

The commit above adds the bidirectional feature. I hope this helps.

@StefOe
Copy link
Owner

StefOe commented Jun 1, 2018

Found a bug with it, so withhold testing for now
Edit: nevermind, was fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants