Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Module from Focus or Category #2

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Conversation

StefanieJaeger
Copy link
Owner

No description provided.

@StefanieJaeger StefanieJaeger changed the title Add Module from Focus Add Module from Focus or Category Nov 16, 2024
@captainwuushuu
Copy link
Collaborator

Maybe add some padding/margin between the listed items in the Vertiefungen, so the buttons don't sit on top of each other. Other than that KUDOS THIS IS FUCKING NICEEEEE

@StefanieJaeger
Copy link
Owner Author

Improved the styling:
image
image
Decided to make the background of the dropdown pink, to have it not disappear into the Semester component. This is temporary tho, until we update the ModuleSearch component.

@StefanieJaeger
Copy link
Owner Author

I will try a slight optimization of the data. Something like an internal state, to not duplicate modules as much.

@StefanieJaeger
Copy link
Owner Author

Also, Jeremy had a good idea. If we realize that adding modules does not work well on Mobile, then we could always hide those buttons. Since we had noone who used Mobile for editing.

@StefanieJaeger StefanieJaeger merged commit 78cffba into main Nov 20, 2024
4 checks passed
@StefanieJaeger StefanieJaeger deleted the SJ/add-referenced-module branch November 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants