Skip to content

Fix/logo homepage#189

Merged
respp merged 4 commits intomainfrom
fix/logo-homepage
Oct 10, 2025
Merged

Fix/logo homepage#189
respp merged 4 commits intomainfrom
fix/logo-homepage

Conversation

@respp
Copy link
Contributor

@respp respp commented Oct 10, 2025

StellarRent Logo

Pull Request | StellarRent

📝 Summary

Provide a brief description of what this PR accomplishes.

🔗 Related Issues

Closes #(issue number) (Replace with the actual issue number).

🔄 Changes Made

Provide a general description of the changes. Include any relevant background information or context to help reviewers understand the purpose of this PR.

🖼️ Current Output

Provide visual evidence of the changes:

  • For small changes: Screenshots.
  • For large changes: Video or Loom link.

🧪 Testing

If applicable, describe the tests performed. Include screenshots, test outputs, or any resources that help reviewers understand how the changes were tested.

✅ Testing Checklist

  • Unit tests added/modified
  • Integration tests performed
  • Manual tests executed
  • All tests pass in CI/CD

⚠️ Potential Risks

List any possible issues that might arise with this change.

🚀 Next Steps & Improvements

This change lays a solid foundation for further optimizations. Some areas that could benefit from future improvements include:

  • 🔹 Performance optimization
  • 🔹 Increased test coverage
  • 🔹 Potential user experience enhancements

💬 Comments

Any additional context, questions, or considerations for reviewers.

Summary by CodeRabbit

  • New Features
    • Added an Invitations page with a two-column layout, table headers, empty-state message, disabled search, and pagination summary.
  • Style
    • Removed the logo from the header for a cleaner top bar.
  • Bug Fixes
    • Standardized requests for more reliable login and data loading; improved handling of empty/no-content responses to prevent errors.
  • Chores
    • Temporarily stubbed notification fetching to keep the UI responsive while the endpoint is finalized.

zintarh and others added 4 commits October 6, 2025 14:47
- Remove stellarrentlogo.png from homepage header
- Fix unreachable code in api.ts (removed duplicate code)
- Replace forEach with for...of loops for better performance
- Fix unused parameter warnings by prefixing with underscore
- Resolve all Biome linting errors
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new Invitations page component, removes the homepage header logo image, and refactors API calls to a unified request helper with standardized headers/credentials and adjusted implementations, including a stubbed notifications API and routing auth login through the new request flow.

Changes

Cohort / File(s) Summary of changes
Invitations Page UI
apps/web/src/app/invitations/page.tsx
Adds client-side InvitationsPage with two-column layout, static grid header, empty state, disabled search/pagination, and RightSidebar composition. Exports default InvitationsPage.
Homepage Header Cleanup
apps/web/src/app/page.tsx
Removes Image logo from <header>, leaving an empty header element; no structural changes elsewhere.
API Request Unification and Module Adjustments
apps/web/src/services/api.ts
Introduces unified _apiCall/apiUtils.request with Bearer token header merge and credentials include; removes legacy fetch paths. Routes authAPI.login through new request; notificationAPI.getNotifications renamed params and now returns stub { data: [], success: true }. Minor formatting/consistency updates across property, wallet, dashboard APIs; no signature changes except notifications.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as UI (Login Form)
  participant authAPI as authAPI
  participant apiUtils as apiUtils.request
  participant Server as Backend

  User->>UI: Submit email/password
  UI->>authAPI: login(email, password)
  authAPI->>apiUtils: request('/auth/login', POST, body)
  apiUtils->>Server: fetch with headers + credentials
  Server-->>apiUtils: 200/4xx/5xx (JSON or 204)
  apiUtils-->>authAPI: parsed response or thrown error
  authAPI-->>UI: Promise resolve/reject
  UI-->>User: Show success or error
Loading
sequenceDiagram
  autonumber
  actor User
  participant UI as UI (Notifications)
  participant notif as notificationAPI.getNotifications

  User->>UI: Open Notifications
  UI->>notif: getNotifications(_userId, _filters)
  note right of notif: Stubbed response (no network)
  notif-->>UI: { data: [], success: true }
  UI-->>User: Render empty list
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45–60 minutes

Possibly related PRs

Poem

A rabbit taps keys in the night,
Invites now have a tidy light.
The header’s logo hops away,
APIs march in one array.
Stubbed notes whisper, “soon we’ll call”—
Till then, sleek paths serve them all. 🐇✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/logo-homepage

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da36d56 and 686aaae.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • apps/web/src/app/invitations/page.tsx (1 hunks)
  • apps/web/src/app/page.tsx (1 hunks)
  • apps/web/src/services/api.ts (11 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@respp respp merged commit 51002a8 into main Oct 10, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants