Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Usability issue #7

Open
xalioth opened this issue Sep 6, 2018 · 3 comments
Open

Mobile Usability issue #7

xalioth opened this issue Sep 6, 2018 · 3 comments
Assignees

Comments

@xalioth
Copy link
Member

xalioth commented Sep 6, 2018

I got this email from google search console:

"Search Console has identified that your site is affected by 4 new Mobile Usability related issues. This means that Mobile Usability may be negatively affected in Google Search results. We encourage you to review and consider fixing these issues.

Content wider than screen
Clickable elements too close together
Viewport not set
Text too small to read"

May be a good first step for web site renewing ?

@alex-w alex-w self-assigned this Sep 8, 2018
@brianzelip
Copy link

brianzelip commented Sep 15, 2018

Hi @xalioth. I've been reading through your source to learn how your site works.

The problem with the forced horizontal scroll on mobile ("Content wider than screen") starts with:

/* file: css/all.css */

/* problem */
#wrapper { width: 900px; }

/* better */
#wrapper { max-width: 900px; }

There are other hard coded widths that also create this problem.

However, just updating #wrapper to a max-width doesn't solve the issue, because the layout and design of other components rely on the current wrapper styles, and more problems arise when wrapper is changed. So there is a lot of work to be done.

The solutions to the other 3 errors mentioned by google feedback are very simple.

I'm willing to work on updating the stellarium.org site. I'd like to find out from the maintainers how much room there is for change to the current front end state. For example:

  • what browser support do you require (ie, can we use flexbox to fix header issues, or does your team want to support ie 9?)
  • are you interested in a handful of small performance tweaks, such as swapping out background-images (like bg-body.jpg) for css gradients
  • interested in using more modern looking font awesome icons in place of the stellarium software download links in the header (ie - the current windows logo is outdated, font awesome has the proper logo)

@brianzelip
Copy link

Putting up some rough sketches here, https://brianzelip.github.io/new.stellarium.org

@xalioth
Copy link
Member Author

xalioth commented Sep 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants